Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for collection view context menus #1817

Closed
wants to merge 1 commit into from

Conversation

drinkius
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 17, 2020

CLA assistant check
All committers have signed the CLA.

@drinkius
Copy link
Contributor Author

It's a counterpart to #1795 which initially didn't support UICollectionView's updated API

@jparise
Copy link
Member

jparise commented May 17, 2020

@drinkius The CI check appears to be failing with a git error:

git checkout --progress --force ac6515566fd7316f3eee1c76e5a174609a452079
##[error]fatal: reference is not a tree: ac6515566fd7316f3eee1c76e5a174609a452079

Could you try rebasing your changes on top of the latest master commit and pushing again?

@bolsinga
Copy link
Contributor

@drinkius Please try rebasing or merging again.

@bolsinga
Copy link
Contributor

bolsinga commented Jun 3, 2020

Is this covered by #1860 now?

@drinkius
Copy link
Contributor Author

drinkius commented Jun 3, 2020

@bolsinga seems so, sorry, was swamped at work lately and didn't have time to add fixes

@drinkius drinkius closed this Jun 3, 2020
@bolsinga
Copy link
Contributor

bolsinga commented Jun 3, 2020

@bolsinga seems so, sorry, was swamped at work lately and didn't have time to add fixes

No problem! I understand completely. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants