Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu iOS 13 API #1795

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Context menu iOS 13 API #1795

merged 1 commit into from
Apr 1, 2020

Conversation

uuttff8
Copy link
Contributor

@uuttff8 uuttff8 commented Apr 1, 2020 •
edited by jparise
Loading

Fixes #1771

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@uuttff8 uuttff8 mentioned this pull request Apr 1, 2020
Closed
@jparise jparise added the iOS 13 label Apr 1, 2020
@jparise jparise merged commit ce0aebf into TextureGroup:master Apr 1, 2020
@jparise
Copy link
Member

jparise commented Apr 1, 2020

Thank you, @uuttff8!

@IvanChan
Copy link
Contributor

IvanChan commented Apr 2, 2020

@jparise @uuttff8 this commit is something missing with nonnull/nullable declare which cause swift code import build error

func tableView(_ tableView: UITableView, contextMenuConfigurationForRowAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration?

func tableView(_ tableView: UITableView, contextMenuConfigurationForRowAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration

That would be 2 different func

@uuttff8
Copy link
Contributor Author

uuttff8 commented Apr 2, 2020 •
edited
Loading

@IvanChan should it be - (nullable UIContextMenuConfiguration *)tableView:(UITableView *)tableView contextMenuConfigurationForRowAtIndexPath:(NSIndexPath *)indexPath point:(CGPoint)point API_AVAILABLE(ios(13.0)); ?

@IvanChan
Copy link
Contributor

IvanChan commented Apr 2, 2020

Swift version will look like below, copy from apple UITableView header

with ? will be nullable

  @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, shouldBeginMultipleSelectionInteractionAt indexPath: IndexPath) -> Bool

    @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, didBeginMultipleSelectionInteractionAt indexPath: IndexPath)

 @available(iOS 13.0, *)
    optional func tableViewDidEndMultipleSelectionInteraction(_ tableView: UITableView)

 @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, contextMenuConfigurationForRowAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration?

 @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, previewForHighlightingContextMenuWithConfiguration configuration: UIContextMenuConfiguration) -> UITargetedPreview?

 @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, previewForDismissingContextMenuWithConfiguration configuration: UIContextMenuConfiguration) -> UITargetedPreview?

@available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, willPerformPreviewActionForMenuWith configuration: UIContextMenuConfiguration, animator: UIContextMenuInteractionCommitAnimating)

jparise added a commit to jparise/Texture that referenced this pull request Apr 2, 2020
@jparise
Add nullable to new ASCommonTableViewDelegate methods
64633e2 
These were recently introduced in TextureGroup#1795 but were missing `nullable`
annotations on their return types.

Also, reorder the declarations to match `UITableView.h`.
@jparise jparise mentioned this pull request Apr 2, 2020
Merged
@jparise
Copy link
Member

jparise commented Apr 2, 2020

Should be fixed by #1796.

jparise added a commit that referenced this pull request Apr 2, 2020
@jparise
Add nullable to new ASCommonTableViewDelegate methods (#1796)
65a65a6 
These were recently introduced in #1795 but were missing `nullable`
annotations on their return types.

Also, reorder the declarations to match `UITableView.h`.
@drinkius drinkius mentioned this pull request May 17, 2020
Closed
piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
@uuttff8 @piotrdebosz
Context menu iOS 13 API (TextureGroup#1795)
3c8cc62
piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
@jparise @piotrdebosz
Add nullable to new ASCommonTableViewDelegate methods (TextureGroup…
881f038 
…#1796)

These were recently introduced in TextureGroup#1795 but were missing `nullable`
annotations on their return types.

Also, reorder the declarations to match `UITableView.h`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

Assignees
No one assigned
Labels
iOS 13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncDelegate for ASTableNode/ASCollectionNode missing forwarding iOS 13 new api
4 participants
@uuttff8 @CLAassistant @jparise @IvanChan