Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout2-layoutspec-types.md #1330

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Update layout2-layoutspec-types.md #1330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update layout2-layoutspec-types.md 
`justifyContent` definition updated.
  • Loading branch information
@knowsudhanshu
knowsudhanshu authored Jan 29, 2019
commit c52ada4712548ccfa9ce7cfceda56675a74131b7
2 changes: 1 addition & 1 deletion docs/_docs/layout2-layoutspec-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ they will be resolved again, causing justifyContent and alignItems to be updated
- `verticalAlignment`. Specifies how children are aligned vertically. Depends on the stack direction, setting the alignment causes either
justifyContent or alignItems to be updated. The alignment will remain valid after future direction changes.
Thus, it is preferred to those properties.
- `justifyContent`. The amount of space between each child.
- `justifyContent`. It defines the alignment along the main axis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While both descriptions are valid, I agree that the new one is clearer because there are cases ("start", "end" and "center") in which the space between each child is zero and yet the alignments are different. Plus, the new description is similar to the one in CSS Flexbox Spec.

Nit: How about "Alignment of children along main axis"? It's consistent with the other descriptions in this page.

- `alignItems`. Orientation of children along cross axis.
- `flexWrap`. Whether children are stacked into a single or multiple lines. Defaults to single line.
- `alignContent`. Orientation of lines along cross axis if there are multiple lines.
Expand Down