Update layout2-layoutspec-types.md #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`justifyContent` definition updated.
|
|
nguyenhuy
reviewed
Jan 29, 2019
| @@ -84,7 +84,7 @@ they will be resolved again, causing justifyContent and alignItems to be updated | |||
| - `verticalAlignment`. Specifies how children are aligned vertically. Depends on the stack direction, setting the alignment causes either | |||
| justifyContent or alignItems to be updated. The alignment will remain valid after future direction changes. | |||
| Thus, it is preferred to those properties. | |||
| - `justifyContent`. The amount of space between each child. | |||
| - `justifyContent`. It defines the alignment along the main axis. | |||
There was a problem hiding this comment.
While both descriptions are valid, I agree that the new one is clearer because there are cases ("start", "end" and "center") in which the space between each child is zero and yet the alignments are different. Plus, the new description is similar to the one in CSS Flexbox Spec.
Nit: How about "Alignment of children along main axis"? It's consistent with the other descriptions in this page.
nguyenhuy
approved these changes
Feb 15, 2019
|
Cool, thank you, @knowsudhanshu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
justifyContentdefinition updated.