fix: Support relative paths with multiple subfolders in Directory.GetFiles #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbreuss
approved these changes
Jul 17, 2023
vbreuss
requested changes
Jul 17, 2023
Tests/Testably.Abstractions.Tests/FileSystem/Directory/GetFilesTests.cs
Outdated
Show resolved
Hide resolved
vbreuss
approved these changes
Jul 17, 2023
vbreuss
pushed a commit
that referenced
this pull request
Jul 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Testably.Abstractions](https://togithub.com/Testably/Testably.Abstractions) | nuget | patch | `2.3.1` -> `2.3.2` | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions)</summary> ### [`v2.3.2`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v2.3.2) #### What's Changed - chore(deps): update dependency microsoft.net.test.sdk to v17.6.0 by [@​renovate](https://togithub.com/renovate) in [#310 - chore(deps): update dependency microsoft.codeanalysis.csharp to v4.6.0 by [@​renovate](https://togithub.com/renovate) in [#311 - chore(deps): update dependency testableio.system.io.abstractions to v19.2.29 by [@​renovate](https://togithub.com/renovate) in [#312 - coverage: Add tests for correct update of the exists cache for IFileInfo and IDirectoryInfo by [@​vbreuss](https://togithub.com/vbreuss) in [#313 - chore(deps): update dependency coverlet.collector to v6 by [@​renovate](https://togithub.com/renovate) in [#314 - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.21 by [@​renovate](https://togithub.com/renovate) in [#315 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.1 by [@​renovate](https://togithub.com/renovate) in [#317 - fix: failing tests on .NET framework by [@​vbreuss](https://togithub.com/vbreuss) in [#320 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.2 by [@​renovate](https://togithub.com/renovate) in [#318 - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.22 by [@​renovate](https://togithub.com/renovate) in [#319 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by [@​renovate](https://togithub.com/renovate) in [#321 - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.23 by [@​renovate](https://togithub.com/renovate) in [#322 - chore(deps): update dependency xunit to v2.5.0 by [@​renovate](https://togithub.com/renovate) in [#323 - chore(deps): update dependency xunit.runner.visualstudio to v2.5.0 by [@​renovate](https://togithub.com/renovate) in [#324 - docs: include information for local testing against the `RealFileSystem` by [@​vbreuss](https://togithub.com/vbreuss) in [#325 - refactor: Use central package management by [@​vbreuss](https://togithub.com/vbreuss) in [#316 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by [@​renovate](https://togithub.com/renovate) in [#326 - feat: Add a sample Directory.Build.props by [@​ElStefan](https://togithub.com/ElStefan) in [#328 - fix: Remove single quotes from test by [@​ElStefan](https://togithub.com/ElStefan) in [#329 - chore(deps): update dependencies by [@​vbreuss](https://togithub.com/vbreuss) in [#333 - fix: Support relative paths with multiple subfolders in Directory.GetFiles by [@​ElStefan](https://togithub.com/ElStefan) in [#332 #### New Contributors - [@​ElStefan](https://togithub.com/ElStefan) made their first contribution in [#328 **Full Changelog**: v2.3.1...v2.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbreuss
pushed a commit
that referenced
this pull request
Jul 18, 2023
#330) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Testably.Abstractions.Testing](https://togithub.com/Testably/Testably.Abstractions) | nuget | patch | `2.3.1` -> `2.3.2` | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions.Testing)</summary> ### [`v2.3.2`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v2.3.2) #### What's Changed - chore(deps): update dependency microsoft.net.test.sdk to v17.6.0 by [@​renovate](https://togithub.com/renovate) in [#310 - chore(deps): update dependency microsoft.codeanalysis.csharp to v4.6.0 by [@​renovate](https://togithub.com/renovate) in [#311 - chore(deps): update dependency testableio.system.io.abstractions to v19.2.29 by [@​renovate](https://togithub.com/renovate) in [#312 - coverage: Add tests for correct update of the exists cache for IFileInfo and IDirectoryInfo by [@​vbreuss](https://togithub.com/vbreuss) in [#313 - chore(deps): update dependency coverlet.collector to v6 by [@​renovate](https://togithub.com/renovate) in [#314 - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.21 by [@​renovate](https://togithub.com/renovate) in [#315 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.1 by [@​renovate](https://togithub.com/renovate) in [#317 - fix: failing tests on .NET framework by [@​vbreuss](https://togithub.com/vbreuss) in [#320 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.2 by [@​renovate](https://togithub.com/renovate) in [#318 - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.22 by [@​renovate](https://togithub.com/renovate) in [#319 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by [@​renovate](https://togithub.com/renovate) in [#321 - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.23 by [@​renovate](https://togithub.com/renovate) in [#322 - chore(deps): update dependency xunit to v2.5.0 by [@​renovate](https://togithub.com/renovate) in [#323 - chore(deps): update dependency xunit.runner.visualstudio to v2.5.0 by [@​renovate](https://togithub.com/renovate) in [#324 - docs: include information for local testing against the `RealFileSystem` by [@​vbreuss](https://togithub.com/vbreuss) in [#325 - refactor: Use central package management by [@​vbreuss](https://togithub.com/vbreuss) in [#316 - chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by [@​renovate](https://togithub.com/renovate) in [#326 - feat: Add a sample Directory.Build.props by [@​ElStefan](https://togithub.com/ElStefan) in [#328 - fix: Remove single quotes from test by [@​ElStefan](https://togithub.com/ElStefan) in [#329 - chore(deps): update dependencies by [@​vbreuss](https://togithub.com/vbreuss) in [#333 - fix: Support relative paths with multiple subfolders in Directory.GetFiles by [@​ElStefan](https://togithub.com/ElStefan) in [#332 #### New Contributors - [@​ElStefan](https://togithub.com/ElStefan) made their first contribution in [#328 **Full Changelog**: v2.3.1...v2.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileSystem.Directory.GetFiles(string path)returns an invalid file path when the argument consists of..and two subfolders, when the current directory was located in the first subfolder.The returned file path contains the second subfolder twice. (e.g.
..\subfolder1\subfolder2\subfolder2\file.txt)