Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: Add tests for correct update of the exists cache for IFileInfo and IDirectoryInfo #313

Merged
merged 3 commits into from
May 21, 2023

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented May 21, 2023

When creating a File or Directory the "Exists" property should only update for the item where Create() was called.

@vbreuss vbreuss added the coverage Additional tests for edge cases or improvement of test coverage label May 21, 2023
@vbreuss vbreuss self-assigned this May 21, 2023
@vbreuss vbreuss changed the title coverage: Add tests for updating the cache for IFileInfo and IDirectoryInfo coverage: Add tests for correct update of the exists cache for IFileInfo and IDirectoryInfo May 21, 2023
@vbreuss vbreuss marked this pull request as ready for review May 21, 2023 07:53
@vbreuss vbreuss merged commit 14d980a into main May 21, 2023
@vbreuss vbreuss deleted the topic/vb/test-refresh-cache-also-for-other-items branch May 21, 2023 08:00
vbreuss added a commit that referenced this pull request Jun 25, 2023
The tests
`Create_ShouldRefreshExistsCacheForCurrentItem_ExceptOnNetFramework`
introduced in #313 fail on .NET Framework.

![image](https://github.com/Testably/Testably.Abstractions/assets/3438234/c972da45-9232-40f6-b5e6-a7ae21cce75c)

Co-authored-by: Valentin Breuß <v.breuss@tig.at>
vbreuss referenced this pull request Jul 18, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[Testably.Abstractions](https://togithub.com/Testably/Testably.Abstractions)
| nuget | patch | `2.3.1` -> `2.3.2` |

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions
(Testably.Abstractions)</summary>

###
[`v2.3.2`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v2.3.2)

#### What's Changed

- chore(deps): update dependency microsoft.net.test.sdk to v17.6.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/310](https://togithub.com/Testably/Testably.Abstractions/pull/310)
- chore(deps): update dependency microsoft.codeanalysis.csharp to v4.6.0
by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/311](https://togithub.com/Testably/Testably.Abstractions/pull/311)
- chore(deps): update dependency testableio.system.io.abstractions to
v19.2.29 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/312](https://togithub.com/Testably/Testably.Abstractions/pull/312)
- coverage: Add tests for correct update of the exists cache for
IFileInfo and IDirectoryInfo by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/313](https://togithub.com/Testably/Testably.Abstractions/pull/313)
- chore(deps): update dependency coverlet.collector to v6 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/314](https://togithub.com/Testably/Testably.Abstractions/pull/314)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.21 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/315](https://togithub.com/Testably/Testably.Abstractions/pull/315)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/317](https://togithub.com/Testably/Testably.Abstractions/pull/317)
- fix: failing tests on .NET framework by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/320](https://togithub.com/Testably/Testably.Abstractions/pull/320)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/318](https://togithub.com/Testably/Testably.Abstractions/pull/318)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.22 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/319](https://togithub.com/Testably/Testably.Abstractions/pull/319)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/321](https://togithub.com/Testably/Testably.Abstractions/pull/321)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.23 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/322](https://togithub.com/Testably/Testably.Abstractions/pull/322)
- chore(deps): update dependency xunit to v2.5.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/323](https://togithub.com/Testably/Testably.Abstractions/pull/323)
- chore(deps): update dependency xunit.runner.visualstudio to v2.5.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/324](https://togithub.com/Testably/Testably.Abstractions/pull/324)
- docs: include information for local testing against the
`RealFileSystem` by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/325](https://togithub.com/Testably/Testably.Abstractions/pull/325)
- refactor: Use central package management by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/316](https://togithub.com/Testably/Testably.Abstractions/pull/316)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/326](https://togithub.com/Testably/Testably.Abstractions/pull/326)
- feat: Add a sample Directory.Build.props by
[@&#8203;ElStefan](https://togithub.com/ElStefan) in
[https://github.com/Testably/Testably.Abstractions/pull/328](https://togithub.com/Testably/Testably.Abstractions/pull/328)
- fix: Remove single quotes from test by
[@&#8203;ElStefan](https://togithub.com/ElStefan) in
[https://github.com/Testably/Testably.Abstractions/pull/329](https://togithub.com/Testably/Testably.Abstractions/pull/329)
- chore(deps): update dependencies by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/333](https://togithub.com/Testably/Testably.Abstractions/pull/333)
- fix: Support relative paths with multiple subfolders in
Directory.GetFiles by [@&#8203;ElStefan](https://togithub.com/ElStefan)
in
[https://github.com/Testably/Testably.Abstractions/pull/332](https://togithub.com/Testably/Testably.Abstractions/pull/332)

#### New Contributors

- [@&#8203;ElStefan](https://togithub.com/ElStefan) made their first
contribution in
[https://github.com/Testably/Testably.Abstractions/pull/328](https://togithub.com/Testably/Testably.Abstractions/pull/328)

**Full Changelog**:
v2.3.1...v2.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbreuss referenced this pull request Jul 18, 2023
#330)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[Testably.Abstractions.Testing](https://togithub.com/Testably/Testably.Abstractions)
| nuget | patch | `2.3.1` -> `2.3.2` |

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions
(Testably.Abstractions.Testing)</summary>

###
[`v2.3.2`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v2.3.2)

#### What's Changed

- chore(deps): update dependency microsoft.net.test.sdk to v17.6.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/310](https://togithub.com/Testably/Testably.Abstractions/pull/310)
- chore(deps): update dependency microsoft.codeanalysis.csharp to v4.6.0
by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/311](https://togithub.com/Testably/Testably.Abstractions/pull/311)
- chore(deps): update dependency testableio.system.io.abstractions to
v19.2.29 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/312](https://togithub.com/Testably/Testably.Abstractions/pull/312)
- coverage: Add tests for correct update of the exists cache for
IFileInfo and IDirectoryInfo by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/313](https://togithub.com/Testably/Testably.Abstractions/pull/313)
- chore(deps): update dependency coverlet.collector to v6 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/314](https://togithub.com/Testably/Testably.Abstractions/pull/314)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.21 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/315](https://togithub.com/Testably/Testably.Abstractions/pull/315)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/317](https://togithub.com/Testably/Testably.Abstractions/pull/317)
- fix: failing tests on .NET framework by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/320](https://togithub.com/Testably/Testably.Abstractions/pull/320)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/318](https://togithub.com/Testably/Testably.Abstractions/pull/318)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.22 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/319](https://togithub.com/Testably/Testably.Abstractions/pull/319)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/321](https://togithub.com/Testably/Testably.Abstractions/pull/321)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.23 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/322](https://togithub.com/Testably/Testably.Abstractions/pull/322)
- chore(deps): update dependency xunit to v2.5.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/323](https://togithub.com/Testably/Testably.Abstractions/pull/323)
- chore(deps): update dependency xunit.runner.visualstudio to v2.5.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/324](https://togithub.com/Testably/Testably.Abstractions/pull/324)
- docs: include information for local testing against the
`RealFileSystem` by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/325](https://togithub.com/Testably/Testably.Abstractions/pull/325)
- refactor: Use central package management by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/316](https://togithub.com/Testably/Testably.Abstractions/pull/316)
- chore(deps): update dependency microsoft.net.test.sdk to v17.6.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/326](https://togithub.com/Testably/Testably.Abstractions/pull/326)
- feat: Add a sample Directory.Build.props by
[@&#8203;ElStefan](https://togithub.com/ElStefan) in
[https://github.com/Testably/Testably.Abstractions/pull/328](https://togithub.com/Testably/Testably.Abstractions/pull/328)
- fix: Remove single quotes from test by
[@&#8203;ElStefan](https://togithub.com/ElStefan) in
[https://github.com/Testably/Testably.Abstractions/pull/329](https://togithub.com/Testably/Testably.Abstractions/pull/329)
- chore(deps): update dependencies by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/333](https://togithub.com/Testably/Testably.Abstractions/pull/333)
- fix: Support relative paths with multiple subfolders in
Directory.GetFiles by [@&#8203;ElStefan](https://togithub.com/ElStefan)
in
[https://github.com/Testably/Testably.Abstractions/pull/332](https://togithub.com/Testably/Testably.Abstractions/pull/332)

#### New Contributors

- [@&#8203;ElStefan](https://togithub.com/ElStefan) made their first
contribution in
[https://github.com/Testably/Testably.Abstractions/pull/328](https://togithub.com/Testably/Testably.Abstractions/pull/328)

**Full Changelog**:
v2.3.1...v2.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage Additional tests for edge cases or improvement of test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants