Bug create folder from MockFileSystem with trailing "\"

[klace92]

Hi I running this in unittest under net framework and I notis that creating a folder trought MockFileSystem -> Directory -> CreateDirectory is miss behaving compared to normal filesytem access. Here is sample code

        [TestMethod]
        public void Test()
        {
            var fullPath = Path.Combine( Directory.GetCurrentDirectory(), "Test");
            var path = $"{fullPath}\\1.02.03.04\\;
            var path2 = $"{fullPath}\\1.02.03.05\\;         
            
            Directory.CreateDirectory(path);
            Directory.CreateDirectory(path2);
            var result = Directory.GetDirectories(fullPath)
                .Select(x => Path.GetFileName(x))
                .ToList();

            var fs = new MockFileSystem();
            fs.Directory.CreateDirectory(path);
            fs.Directory.CreateDirectory(path2);

            var result2 = fs.Directory.GetDirectories(fullPath)
                .Select(x => fs.Path.GetFileName(x))
                .ToList();

            Assert.IsTrue(result.SequenceEqual(result2), $"From system: {string.Join(", ", result)}. From mock {string.Join(", ", result2)}");
        }

The result form this is

Assert.IsTrue failed. From system: 1.02.03.04, 1.02.03.05. From mock , 

The result2 contains two item but both is empty strings. If I'm remove the trailing "\" from "path" and "path2" it return correct item but order is reversed.

[vbreuss]

@klace92: I will have to check what the issue with the trailing \ is (the GetDirectories() method should not return strings with trailing slash), but I won't have time the next couple of days. Do you want to have a look?

The second point regarding the item order: .NET does not guarantee any order in GetDirectories or GetFiles, so I don't think this is an issue.

[klace92]

@vbreuss I'm sadly a bit busy myself but I'm not in a hurry because a wrokaround is to to remove trailing "" from the path and it works as should. But still think the mock system should atleast behave the same a real system.

On second point I was sure on the correct behavior so put it in what notis when I found a workaround.

[github-actions]

This is addressed in release v4.3.4.

[vbreuss]

I think I found the issue. Can you please check, if it works as expected in the latest version, @klace92 ?

[klace92]

Yes Thank you @vbreuss for the quick fix.