fix: trim trailing slash in Directory.GetDirectories

[vbreuss]

This PR fixes the Directory.GetDirectories method to trim trailing slashes from directory paths in the returned results. This ensures consistent behavior where directory paths returned by enumeration methods don't include trailing directory separators.

Key changes:

• Adds helper method TrimTrailingDirectorySeparator for consistent path normalization
• Updates directory enumeration logic to remove trailing slashes from results
• Includes comprehensive test coverage for both GetDirectories and EnumerateDirectories methods

---

• Fixes Bug create folder from MockFileSystem with trailing "\" #850

[Copilot]

Pull Request Overview

This PR fixes the Directory.GetDirectories method to trim trailing slashes from directory paths in the returned results. This ensures consistent behavior where directory paths returned by enumeration methods don't include trailing directory separators.

• Adds helper method TrimTrailingDirectorySeparator for consistent path normalization
• Updates directory enumeration logic to remove trailing slashes from results
• Includes comprehensive test coverage for both GetDirectories and EnumerateDirectories methods

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Tests/Testably.Abstractions.Tests/FileSystem/Directory/GetDirectoriesTests.cs	Adds new test case to verify trailing directory separators are trimmed from results
Tests/Testably.Abstractions.Tests/FileSystem/Directory/EnumerateDirectoriesTests.cs	Adds new test case for EnumerateDirectories and fixes code formatting
Tests/Testably.Abstractions.Tests/FileSystem/Directory/CreateDirectoryTests.cs	Minor code formatting improvement
Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs	Updates enumeration logic to trim trailing separators and improves code formatting
Source/Testably.Abstractions.Testing/Helpers/PathHelper.cs	Adds new helper method for trimming trailing directory separators
Source/Testably.Abstractions.Testing/FileSystem/DirectoryMock.cs	Applies trailing separator trimming to directory enumeration results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

    37 files  ±  0      37 suites  ±0   21m 22s ⏱️ -1s
44 130 tests + 18  41 701 ✅ +14  2 429 💤 + 4  0 ❌ ±0 
85 856 runs  +128  76 825 ✅ +88  9 031 💤 +40  0 ❌ ±0 

Results for commit e6313c4. ± Comparison against base commit f66fee3.

This pull request removes 36171 and adds 36189 tests. Note that renamed tests count towards both.

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3b76aa09-3e52-46f7-bfaa-5cac42db9336")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path449a0c4e-6e47-4f03-b30b-ad9f4f5213d3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path59890de6-4a06-488e-b1d0-d9eb244d5f3a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5e02e941-74f2-4743-a407-71ccf8bed9e7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path63b3ac1e-03f5-4caf-8fe9-197231255441")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path667a96b2-94a4-4051-add8-7ed726eb7158")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha5e7d9a3-2a2c-49cb-a630-949a6a6be9c8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2945530d-8934-4240-a309-9af0d3197521")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path51a3253e-4473-4de6-bfc4-46f8d6e91905")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path8225866d-8b7f-4cf0-bc86-351cfff7c6dd")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1409ef2e-7ea3-4f7d-9a44-851f0afdcbc7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2ce882f5-7640-4923-9129-1bd8e36fbe40")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha336504f-0569-471a-8356-1086bb138241")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathaaf94142-bddb-46e4-a7fa-f71118960a89")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathcbd14833-47d4-43ec-8d63-4fac795c74d0")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdcfb0777-de57-4a3c-b90f-86bd672aaef1")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdf7274ad-7f21-4177-941b-2011b766384e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path00022c43-3aed-4b27-93d2-f1aeeaab67ab")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path682e0f3e-9a15-4905-95b5-32b6b6db84f8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6c341df6-1ab8-47df-8320-2188db4ac6bb")
…

This pull request removes 1784 skipped tests and adds 1788 skipped tests. Note that renamed tests count towards both.

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3b76aa09-3e52-46f7-bfaa-5cac42db9336")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path449a0c4e-6e47-4f03-b30b-ad9f4f5213d3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path59890de6-4a06-488e-b1d0-d9eb244d5f3a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path63b3ac1e-03f5-4caf-8fe9-197231255441")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2945530d-8934-4240-a309-9af0d3197521")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path8225866d-8b7f-4cf0-bc86-351cfff7c6dd")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe04ff3ba-a5df-4231-b66d-840c7670c0c5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe57f1597-360a-4518-b081-00ff5caffadb")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path424111f8-1953-4bd5-92d9-d076633d64ab")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path4dc458db-6d4b-4437-97d7-f2a0d89fa202")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2ce882f5-7640-4923-9129-1bd8e36fbe40")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha336504f-0569-471a-8356-1086bb138241")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathcbd14833-47d4-43ec-8d63-4fac795c74d0")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdcfb0777-de57-4a3c-b90f-86bd672aaef1")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path682e0f3e-9a15-4905-95b5-32b6b6db84f8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path8dcb83fe-3b59-47bf-a6bd-d6c587e409e7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path8e3b298e-5619-4fdc-b2b2-c9a5ed989659")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path99916cd3-8876-4227-a289-9147e393be30")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path4200f9af-04c5-4f17-ac5c-89c9a0ba1c91")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path4555c27c-9863-4f97-b732-e08c8889ecc5")
…

[github-actions]

This is addressed in release v4.3.4.