Asynchronous HTTP 202 + user cancellation #3038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Knockout binding from CesiumSelectionIndicator
Add rel="noreferrer noopener" to links.
Fix sort order for share URLs.
cahnges in master release v6.0.5 are really important!!
…nCatalogFunction uses a request and a listener for ResultPendingCatalogItem.isEnabled to cancel an HTTP 202 asynchronous request
|
Is there going to be any more feedback for this pull request?
Thanks
Jason
Jason D’Netto | e-Research Analyst/Research Support Specialist | eResearch | Queensland University of Technology (QUT) | 2 George St, GPO Box 2434, Brisbane 4001 AUSTRALIA | CRICOS 00213J | Phone : 3138 4478 | Email : j.dnetto@qut.edu.au<mailto:j.dnetto@qut.edu.au>
From: Kevin Ring [mailto:notifications@github.com]
Sent: Thursday, 16 August 2018 10:43 AM
To: TerriaJS/terriajs <terriajs@noreply.github.com>
Cc: Jason D'Netto <j.dnetto@qut.edu.au>; Author <author@noreply.github.com>
Subject: Re: [TerriaJS/terriajs] Asynchronous HTTP 202 + user cancellation (#3038)
Closed #3038<#3038>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3038 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AXIqZeb9NgHIK5I1EFV8Jv7R3-YObdDuks5uRMAhgaJpZM4Vb4Ko>.
|
|
Yes! Sorry for the delay. |
|
Apparently GitHub closed this when I deleted the |
|
Actually, #3037 is fine, no need to open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiating the cesium Request object in TerriaJsonCatalogItem and passing it down through to cesium Resource objects, so that the user clicking 'Remove' on the ResultPendingCatalogItem cancels the Request in the request object and stops creating xhr calls.
made against the cesium-1.46 branch as requested in #3037