Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous HTTP 202 + user cancellation #3037

Open
wants to merge 13 commits into
base: terriajs7
Choose a base branch
from

Conversation

Jason-DNetto
Copy link
Contributor

Instantiating the cesium Request object in TerriaJsonCatalogItem and passing it down through to cesium Resource objects, so that the user clicking 'Remove' on the ResultPendingCatalogItem cancels the Request in the request object and stops creating xhr calls.

@kring
Copy link
Member

kring commented Jul 24, 2018

Thanks @Jason-DNetto! Can I bug you to make this a PR into the cesium-1.46 branch? Much easier to review that way.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kring
❌ Jason-DNetto
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants