Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): line charts wouldn’t render with empty data set #138

Merged
merged 1 commit into from
Nov 9, 2016
Merged

fix(charts): line charts wouldn’t render with empty data set #138

merged 1 commit into from
Nov 9, 2016

Commits on Nov 8, 2016

  1. fix(charts): line charts wouldn’t render with empty data set 

    The line chart wouldn’t render at all if an empty array is used on the
[data] attribute, the following error would be thrown:

TypeError: Cannot read property 'xValue' of undefined

I narrowed it down to the translation of the data, where it was assumed
that the value would be defined at all times, which isn’t the case if
data is an empty array.

This fix solves the problem.
    @fcoury
    fcoury committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    74002f1 View commit details
    Browse the repository at this point in the history