fix(charts): line charts wouldn’t render with empty data set #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line chart wouldn’t render at all if an empty array is used on the [data] attribute, the following error would be thrown: TypeError: Cannot read property 'xValue' of undefined I narrowed it down to the translation of the data, where it was assumed that the value would be defined at all times, which isn’t the case if data is an empty array. This fix solves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The line chart wouldn’t render at all if an empty array is used on the [data] attribute, the following error would be thrown:
TypeError: Cannot read property 'xValue' of undefinedI narrowed it down to the translation of the data, where it was assumed that the value would be defined at all times, which isn’t the case if data is an empty array.
This fix solves the problem.
What's included?
Test Steps
src/app/components/components/charts.component.html<td-chart-line, replacingdataSrc="..."by[data]="[]"Screenshots or link to CodePen/Plunker/JSfiddle
The error is the following: