Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Docker Container Functionality and Lifecycle Management Facilities #175

Merged
merged 20 commits into from
May 22, 2021
Merged

✨ Add Docker Container Functionality and Lifecycle Management Facilities #175

merged 20 commits into from
May 22, 2021

Commits on May 22, 2021

  1. 🔧 Add discrete container registry username field

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    3521ef6 View commit details
    Browse the repository at this point in the history

  2. ✨ Add container registry variables

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    3134388 View commit details
    Browse the repository at this point in the history

  3. ✨ Add container image and tag variables 

    Based on the pre-existing strong version tagging support.
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9078b3d View commit details
    Browse the repository at this point in the history

  4. ✨ Add Make target env var validation helper function

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    eae3040 View commit details
    Browse the repository at this point in the history

  5. ✨ Add Docker container pull/push/build targets

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    846788c View commit details
    Browse the repository at this point in the history

  6. 🚀 Add universal Dockerfile

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    f930871 View commit details
    Browse the repository at this point in the history

  7. ✨ Conditionally create basic Jupyter container image

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    499e1d5 View commit details
    Browse the repository at this point in the history

  8. ✨ Conditionally add Jupyter container image deployment targets

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    ecc6eeb View commit details
    Browse the repository at this point in the history

  9. ✨ Conditionally add non-Jupyter container image deployment targets

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    e004ce0 View commit details
    Browse the repository at this point in the history

  10. 🍪 Add Docker container feature documentation

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    e75e727 View commit details
    Browse the repository at this point in the history

  11. ✨ Add or mount application files conditioned on the project_type co… 

    …nfiguration
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    d3dc153 View commit details
    Browse the repository at this point in the history

  12. ✨ Condition mounting of application directory on user-defined env var 

    - Excluding root project files by default
- Switching to mount syntax as per the official Docker documentation
recommendation
    - See Also: https://docs.docker.com/storage/bind-mounts/
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    dcb6678 View commit details
    Browse the repository at this point in the history

  13. ✨ Add option to run container interactively 

    Conditioned on user-defined env var.
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    fb52bed View commit details
    Browse the repository at this point in the history

  14. 🔧 Add application files by default 

    Since the common use-case is distributing application code with
container images, copying application files by default. The onus is on
users to delete the associated COPY directive if they want to distribute
 a dependency-only image.
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    0f1a864 View commit details
    Browse the repository at this point in the history

  15. ✨ Add universal entrypoint support

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    22a9510 View commit details
    Browse the repository at this point in the history

  16. ♻️ Rename BIND_MOUNT_PROJECT_DIR_ON_CONTAINER to `BIND_MOUNT_APPLIC… 

    …ATION_DIR_ON_CONTAINER`
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9b67e67 View commit details
    Browse the repository at this point in the history

  17. 📝 Add Docker container feature documentation

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    b417822 View commit details
    Browse the repository at this point in the history

  18. ♻️ Condense conditional generation logic for container deployment tar… 

    …gets
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    4011608 View commit details
    Browse the repository at this point in the history

  19. 📝 Add Docker container development documentation

    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    39061d5 View commit details
    Browse the repository at this point in the history

  20. 💚 Fix CI failures from unparseable Makefile 

    i.e.,
```
Run make provision-environment
  make provision-environment
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.5/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.5/x64/lib
Makefile:153: *** missing separator.  Stop.
Error: Process completed with exit code 2.
```

Runs fine locally with same shell and flag, expediently fixing error by
marking template as a comment. We must live with an extraneous hash
symbol.
    @TeoZosa
    TeoZosa committed May 22, 2021
    Configuration menu
    Copy the full SHA
    5959e14 View commit details
    Browse the repository at this point in the history