✨ Add Docker Container Functionality and Lifecycle Management Facilities #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the pre-existing strong version tagging support.
- Excluding root project files by default
- Switching to mount syntax as per the official Docker documentation
recommendation
- See Also: https://docs.docker.com/storage/bind-mounts/
Conditioned on user-defined env var.
Since the common use-case is distributing application code with container images, copying application files by default. The onus is on users to delete the associated COPY directive if they want to distribute a dependency-only image.
…ATION_DIR_ON_CONTAINER`
TeoZosa
added
documentation
i.e.,
```
Run make provision-environment
make provision-environment
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.9.5/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.5/x64/lib
Makefile:153: *** missing separator. Stop.
Error: Process completed with exit code 2.
```
Runs fine locally with same shell and flag, expediently fixing error by
marking template as a comment. We must live with an extraneous hash
symbol.
TeoZosa
force-pushed
the
add-docker-container-support
branch
from
a804e92
to
5959e14
Compare
TeoZosa
added a commit
that referenced
this pull request
May 22, 2021
TeoZosa
added a commit
that referenced
this pull request
May 22, 2021
TeoZosa
added a commit
that referenced
this pull request
May 22, 2021
TeoZosa
added a commit
that referenced
this pull request
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic "production" container creation and management features.
build/push/pull/deploylogic abstracted into correspondingmake` targets for better ergonomics