Skip to content

Make spawn-rpc "return" url instead of logging/printing it #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beruda merged 2 commits into from
Oct 26, 2023
Merged

Make spawn-rpc "return" url instead of logging/printing it #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b05ac
Make `spawn-rpc` "return" url instead of logging/printing it
beruda Oct 24, 2023
6ce4be7
return as optional flag to not introduce breaking changes
beruda Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion commands/devnet/spawn_rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package devnet

import (
"fmt"
"os"

"github.com/pkg/errors"
Expand All @@ -16,6 +17,7 @@ var projectSlug string
var templateSlug string
var accessKey string
var token string
var returnUrl bool

func init() {
cmdSpawnRpc.PersistentFlags().StringVar(
Expand Down Expand Up @@ -48,6 +50,12 @@ func init() {
"",
"The Tenderly JWT. If not provided, the system will try to read 'token' from the 'tenderly.yaml' configuration file.",
)
cmdSpawnRpc.PersistentFlags().BoolVar(
&returnUrl,
"return-url",
false,
"Optional flag to return the URL instead of printing it. Default: false.",
)
CmdDevNet.AddCommand(cmdSpawnRpc)
}

Expand Down Expand Up @@ -118,5 +126,10 @@ func spawnRPCHandler(cmd *cobra.Command, args []string) {
logrus.Error("Failed to spawn RPC", err)
return
}
logrus.Info(response)

if returnUrl {
fmt.Printf("%s\n", response)
} else {
logrus.Info(response)
}
}