Skip to content

Conversation

@beruda
Copy link
Contributor

@beruda beruda commented Oct 24, 2023

Current implementation just prints the URL instead of returning it, so the current command can't be used in bash scripts.

Current implementation just prints the URL instead of returning it, so the current command can't be used in bash scripts.
@beruda
Copy link
Contributor Author

beruda commented Oct 24, 2023

Running

test=$(tenderly version)

won't print anything, but echo $test after it will.

But running

rpc=$(tenderly devnet spawn-rpc --project testerly --account beruda --access_key $API_KEY --template all-purpose-support-testing)

will print the URL, but it won't be written to the rpc env variable; i.e. echo $rpc won't print the URL.

So I just changed this command to return the value using fmt.Printf just like the version command.

Copy link
Contributor

@daleksov daleksov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional flag is way more safe. So I'm OK with this approach, since we are not going to affect any of the existing integrations.

@beruda beruda merged commit 0add238 into master Oct 26, 2023
@beruda beruda deleted the beruda/spawn-rpc-patch branch October 26, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants