Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for "Play All" #9568

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

pratyaksh1610
Copy link
Contributor

@pratyaksh1610 pratyaksh1610 commented Dec 19, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Added icon for "Play All"

Before/After Screenshots/Screen Record

Before After
Before After

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr TobiGr added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Dec 19, 2022
@TobiGr
Copy link
Member

TobiGr commented Dec 19, 2022

LGTM, the only thing we need to keep in mind is how to handle small screens. I think this was initially the reason why the icon was missing. However, I think we also "lost" many devices with very small displays as we dropped KitKat support. I am not sure whether the whole topic is an issue any more, but at least something we need to think about for a moment.
Screenshot_20221219_221016

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TobiGr I think the problem does not lie in this specific PR, but rather in the playlist control header which does not scale well to small screens. This PR just adds an icon to one button which in German happens to have more text than other buttons, but for other languages it might be different.

@Stypox Stypox merged commit cd0e585 into TeamNewPipe:dev Jan 1, 2023
@pratyaksh1610 pratyaksh1610 deleted the branch-add-play-all-icon branch January 1, 2023 17:24
@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
@AudricV AudricV changed the title Added icon for "Play All" Add icon for "Play All" Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon for "Play All"
3 participants