-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.25.0 (please TEST!) #9712
Comments
Confirmation from others might be needed, but when I resize the popup player, its size jumps around for a moment, something like flashing, and after that it ends up away from one of the fingers, making swiping-adjusting uncomfortable. Edit: I just thought to install a debug build from 0.24.1 release and test it, and the same happens, so I guess you can ignore this report. Either I never noticed this happens, or it has something to do with my current system. |
Not really an problem, more an cosmetical issue: Since the introduction of the new card view and raising the item size on tv (previously 5, now 3 items per row) the resolution of the thumbnails is way too low. They look blurry and show artifacts. People may be complaining about that. 🙄🤭 So would it be possible to get Anyways, great job so far. 😁👍 |
Clicking twice is now required for showing video interface. First one for showing soft buttons, second one for video interface. This should not be the case as swiping from soft buttons' edge shows soft buttons. Screenrecorder-2023-01-22-19-38-46-579.mp4 |
Not sure if |
This comment was marked as off-topic.
This comment was marked as off-topic.
@peat80 I something similar on my Razer Phone 2. While the items per row under the subscription tab remained the same (4), they are now much larger and very blurry. Personally, I would have preferred for them to remain the same size, but to reduce the amount of space between them by fitting 5 items (I have the space for that, since I set everything to be at the smallest size in the system settings). |
Clicking on |
This comment was marked as resolved.
This comment was marked as resolved.
Check this #9615 |
Well, #9615 doesn't seem to be device specific. My device is on MIUI 12.5. |
This bug is specific to Android 13 :) |
But my device is on Android 11, MIUI 12.5 |
There is a known issue with the new ExoPlayer version on certain Android versions/devices. This makes the video stutter at a certain resolution. I have tested the new version of NewPipe on my Device (Nokia 6.1 Android 10 Vanilla) and from a resolution of 720p60fps and higher, the problem is present. Zapp also has the problem and is waiting for an update of ExoPlayer which may fix the problem. Xtra has/had the problem too, but was able to solve it with a hadware decoder. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I published Release Candidate 2, which includes these changes:
|
@peat80 Definitely not, unfortunately. It will take a while ;-)
@SameenAhnaf This is likely caused by #8894. @Isira-Seneviratne could you look into it? |
Sure, I'll take a look when I get home. |
@SameenAhnaf On which Android version(s) did you get this issue? I checked on Android 6 and 13, and I didn't face any issues. |
my device is on Android 11, MIUI 12.5 |
Thanks for the info, I'll look into the issue. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@SameenAhnaf I checked on a device running Android 11, and the system bars displayed fine when tapping the video player once. device-2023-02-03-193914.mp4 |
I tried once again to reproduce the two issues that SameenAhnaf is having on MIUI, but since I have no such device myself, I couldn't reproduce. So for now I'm publishing this release, then we'll see if someone is able to fix those issues in the next release. |
0.25 isn't on your F-Droid repo yet |
Sorry for the delay. The update is available trough our F-Droid repo now. |
Testing for regressions
Debug APK (built by @Stypox): NewPipe_v0.25.0_RC2_debug.zip
Release APK (built and signed by @Stypox): NewPipe_v0.25.0_RC2_release.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases!
TODO
NewPipeExtractor version
This version of NewPipe will ship with NewPipeExtractor commit 7e793c11aec46358ccbfd8bcfcf521105f4f093a (still WIP)
App changelog
New
Improved
compileSdk
andtargetSdk
to 33 (Android 13) Set compileSdk and targetSdk to 33 (Android 13) #9306 Fix popup enablement toast crash on API 33 #9671 Fix NPEs after OnSharedPreferenceChangeListener changes #9696Fixed
Localization
Development
PendingIntent
s immutable on Android 6.0 and later Make PendingIntents immutable on Android 6.0 and later. #9333Locale.forLanguageTag()
Use Locale.forLanguageTag(). #8870@Nullable
and@NotNull
annotation imports Forbid wrong@Nullable
and@NotNull
annotation imports #9474Math.floorDiv()
Use Math.floorDiv(). #8810SparseArrayCompat
Use SparseArrayCompat. #8895VideoDetailFragment
Refactor VideoDetailFragment. #8847VideoPlayerUi
Refactor VideoPlayerUi. #9159ListAdapter
inNotificationModeConfigAdapter
Use ListAdapter in NotificationModeConfigAdapter. #8841Optional
-related code Clean up Optional-related code. #9285 Use Optional.map() instead of flatMap(). #9663WindowCompat
Use WindowCompat. #8894desugar_jdk_libs
to 2.0.0 and Android Gradle Plugin to 7.4.0 (which requires Android Studio Electric Eel) Update desugar_jdk_libs to 2.0.0. #9686The text was updated successfully, but these errors were encountered: