-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Runnable variables for Handlers. #8886
Remove Runnable variables for Handlers. #8886
Conversation
5f5fca6
to
39b3f04
Compare
Kudos, SonarCloud Quality Gate passed! |
39b3f04
to
c30f787
Compare
Kudos, SonarCloud Quality Gate passed! |
You have added many unrelated changes (e.g. code style) and have not explained well what you did and how and why you did it. Please remove the unrelated changes and add a better PR description. |
c30f787
to
956fbd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, now I can see what's happening. I think it's better to use string constants instead of duplicating the strings (I'm referring to "doubleTap", "next", "show", which should be converted to DOUBLE_TAP, NEXT, SHOW).
956fbd1
to
d018556
Compare
d018556
to
9514316
Compare
(the tests were failing)
|
Kudos, SonarCloud Quality Gate passed! |
What is it?
Description of the changes in your PR
Runnable
variables being used in the downloader and double tap functionality with lambdas, and use String constants to keep track of them in the Handlers.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence