Long-click on stream segment to share timestamped url #9203
Conversation
…k for each chapter
| String videoUrl = player.getVideoUrl(); | ||
| videoUrl += ("&t=" + seconds); | ||
| ShareUtils.shareText(context, currentItem.getTitle(), | ||
| videoUrl, currentItem.getThumbnailUrl()); |
There was a problem hiding this comment.
This won't work for services other than YouTube. You should use the same logic as in the player:
There was a problem hiding this comment.
Hey sorry for clarification, do you mean that I should be surrounding line 714 with an if statement checking that the service ID is indeed YouTube? I did look at this part in the player but thought it might not be necessary since I thought that these click handlers on the segments would only ever be called from a YouTube service. Sorry if I am misunderstanding and thanks for the quick replies!
And yes I am an ANU student :)
There was a problem hiding this comment.
I thought that these click handlers on the segments would only ever be called from a YouTube service
That's probably true, but who knows if a future service will support segments ;-)
Yes, sorround it with a "is youtube" check. If it's not YouTube, don't allow long-pressing the item at all.
There was a problem hiding this comment.
Hey, I have been attempting to add this check to the buildSegements function with setLongClickable(false), however even with setOnLongClickListener(null), the long click event still occurs. Similarly, the existing onClick method used for seeking to different chapters does not get disabled by setting clickable to false. I have also tried adding the check to the beginning of the long click call, however since the call consumes the click event, this is not the desired result.
don't allow long-pressing the item at all.
Is there some better way of doing this that I am unaware of? Thanks
There was a problem hiding this comment.
Ok, then it's fine if you just don't do anything when a long-press is detected but the url is non-youtube
SameenAhnaf
added
feature request
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
changed the title
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence