Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapter timestamp share #8343

Closed
5 tasks done
ghost opened this issue May 3, 2022 · 4 comments · Fixed by #9203
Closed
5 tasks done

chapter timestamp share #8343

ghost opened this issue May 3, 2022 · 4 comments · Fixed by #9203
Assignees
Labels
feature request Issue is related to a feature in the app

Comments

@ghost
Copy link

ghost commented May 3, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Can be implemented either in two ways:

  1. Put share button beside each chapter
  2. Or Hold the chapter to share the link with the chapter timestamp included

Why do you want this feature?

To quickly share the link with timestamp included, so that the stream would play from that timestamp instead of beginning.

Additional information

As an example, the timestamp option append looks like &t=1m30s at the end of the link

@ghost ghost added the feature request Issue is related to a feature in the app label May 3, 2022
@ghost ghost changed the title hold chapters to share with timestamp chapter timestamp share May 3, 2022
@Callisto404
Copy link

Hey, I'd like to attempt this feature if that is okay.

@opusforlife2
Copy link
Collaborator

@Callisto404 Great! Could you give a rough idea of how you will implement this, before taking this up?

@Callisto404
Copy link

Callisto404 commented Oct 13, 2022

Hey @opusforlife2, first time contributor so correct me on anything and everything. To my knowledge the segmentAdapter in the MainPlayerUI class uses the getStreamSegmentListener() to implement the interface which is described in the StreamSegmentAdapter Kotlin class. If we wanted to use the OP's 2nd option for sharing with a long click could I just change the Kotlin interface to also require an onItemLongClick method with which I can use the ShareUtils class to share with the timestamp of that chapter?
I'm sure I am misunderstanding something so any feedback is welcome, thanks.

@opusforlife2
Copy link
Collaborator

I'm not a dev, sorry. I'll see if a team dev can have a look at your question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants