-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chapter timestamp share #8343
Comments
Hey, I'd like to attempt this feature if that is okay. |
@Callisto404 Great! Could you give a rough idea of how you will implement this, before taking this up? |
Hey @opusforlife2, first time contributor so correct me on anything and everything. To my knowledge the segmentAdapter in the MainPlayerUI class uses the getStreamSegmentListener() to implement the interface which is described in the StreamSegmentAdapter Kotlin class. If we wanted to use the OP's 2nd option for sharing with a long click could I just change the Kotlin interface to also require an onItemLongClick method with which I can use the ShareUtils class to share with the timestamp of that chapter? |
I'm not a dev, sorry. I'll see if a team dev can have a look at your question. |
Checklist
Feature description
Can be implemented either in two ways:
Why do you want this feature?
To quickly share the link with timestamp included, so that the stream would play from that timestamp instead of beginning.
Additional information
As an example, the timestamp option append looks like
&t=1m30s
at the end of the linkThe text was updated successfully, but these errors were encountered: