Added loading of items when the view can't be scrolled #7638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
bug
triallax
suggested changes
Jan 10, 2022
app/src/main/java/org/schabi/newpipe/fragments/list/BaseListFragment.java
Show resolved
Hide resolved
…agment.java Co-authored-by: Mohammed Anas <triallax@tutanota.com>
|
Kudos, SonarCloud Quality Gate passed! |
litetex
reviewed
Jan 13, 2022
There was a problem hiding this comment.
Thank you for the PR 😄
It seems to work but:
this seems to work just by sheer luck:
I don't know who designed an API that calls onScrolled when no scroll event occurs...- This will be called whenever a scroll occurs - that can be quite resource intensitive
Let's have a look at the problem:
So there is not enough data initially loaded.
Then I think we should load enough data initially:
- initially load the data
- if there is more data loadable and the view is not scrollable → load more data
- repeat above if needed
I will try to create a PR for my mentioned resolution this week.
litetex
requested changes
Jan 14, 2022
There was a problem hiding this comment.
Sorry but I have to block the PR:
Tested the PR again - on a tablet and with grid mode - and the search crashes in >60% of all cases:
NP7638NW.gif.mp4
PS: I'm still working on the PR but I run into some unexpected errors when using RecyclerView which might be related to #4475
This was referenced Jan 15, 2022
litetex
added a commit
to litetex/NewPipe
that referenced
this pull request
Jan 16, 2022
The previous/reverted behavior caused unwanted data transmission: * Removed loading via handleResults/loadMoreItems-callback because the RecyclerView is apparently not immediately updated in the UI when the data is set which causes one load of data to much.
|
Superseded by #7659 Anyway thank you for the work 😄 |
litetex
added a commit
to litetex/NewPipe
that referenced
this pull request
Jan 16, 2022
The previous/reverted behavior caused unwanted data transmission: * Removed loading via handleResults/loadMoreItems-callback because the RecyclerView is apparently not immediately updated in the UI when the data is set which causes one load of data to much.
litetex
added a commit
to litetex/NewPipe
that referenced
this pull request
Jan 24, 2022
The previous/reverted behavior caused unwanted data transmission: * Removed loading via handleResults/loadMoreItems-callback because the RecyclerView is apparently not immediately updated in the UI when the data is set which causes one load of data to much.
litetex
added a commit
to litetex/NewPipe
that referenced
this pull request
Feb 17, 2022
The previous/reverted behavior caused unwanted data transmission: * Removed loading via handleResults/loadMoreItems-callback because the RecyclerView is apparently not immediately updated in the UI when the data is set which causes one load of data to much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
Comment:
I ran into the bug Crash in lists (ViewHolder views not attached) #4475 several times when I was testing the grid view on a tablet emulator. I just wanted to make you aware of that.
I didn't know how to test the local list
Due diligence