-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instead of crashing, or showing an error, can Newpipe just... not scroll? #3368
Comments
Slightly different crash on 0.21.9 (caught by Scoop, not Newpipe):
|
I think the problem might be related to NewPipe/app/src/main/java/org/schabi/newpipe/info_list/InfoListAdapter.java Lines 293 to 296 in 9ff1bae
According to https://stackoverflow.com/a/42865352 and https://speakerdeck.com/yigit/pro-recyclerview?slide=94 (found in a similar google issue) every viewholder has to create/inflate it's own view. Related to #4475 Update: Okay, this problem and #4475 are definitely caused by the above code.
Update2: |
* Always recreate the footer so that it's not possible to attach the same instance twice * Removed support for creating a custom footer as it's never used * Supply the header with an supplier * This might not fix the problem completely as we currently can only create the header once inside Channel, Playlist and RelatedItems-Fragment - allowing creation of multiple headers might be done in the future if the issues still arise * Other minor fixes
* Always recreate the footer so that it's not possible to attach the same instance twice * Removed support for creating a custom footer as it's never used * Supply the header with an supplier * This might not fix the problem completely as we currently can only create the header once inside Channel, Playlist and RelatedItems-Fragment - allowing creation of multiple headers might be done in the future if the issues still arise * Other minor fixes
@litetex congratulations for that finding! It's a really nasty bug and I couldn't understand the issue even after debugging on multiple occasions... :-D |
* Always recreate the footer so that it's not possible to attach the same instance twice * Removed support for creating a custom footer as it's never used * Supply the header with an supplier * This might not fix the problem completely as we currently can only create the header once inside Channel, Playlist and RelatedItems-Fragment - allowing creation of multiple headers might be done in the future if the issues still arise * Other minor fixes
* Always recreate the footer so that it's not possible to attach the same instance twice * Removed support for creating a custom footer as it's never used * Supply the header with an supplier * This might not fix the problem completely as we currently can only create the header once inside Channel, Playlist and RelatedItems-Fragment - allowing creation of multiple headers might be done in the future if the issues still arise * Other minor fixes
Version
Steps to reproduce the bug
Expected behavior
Since Newpipe can't load new items in the list without internet, it should just not scroll after the last already loaded one. You could mention the network error and show the retry button in the space below the last list item.
Actual behaviour
Screen clears and shows Network Error with a Retry button.
In rare cases like I just got, crash. UI error. It seems to involve the AndroidX RecyclerView.
Interestingly, with this error page, tapping back takes you to the home screen, but you can open Newpipe from its launcher and use it without any error. If you tap back from there, though, you're taken to the error page again. It's in the backstack or something.
If you turn internet back on and then open Newpipe, it removes the error page from the backstack.
Logs
Exception
Crash log
The text was updated successfully, but these errors were encountered: