Using Zulu in GH actions

[carldea]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• The CI build workflow uses Zulu as its setup-java version distribution. AdoptOpenJDK is discontinued.

Before/After Screenshots/Screen Record

• Before: N/A
• After: N/A

Fixes the following issue(s)

• Fixes Using Zulu in GH actions #6988 The CI build test was successful. https://github.com/carldea/NewPipe/actions

Due diligence

• I read the contribution guidelines.

[triallax]

https://github.com/actions/setup-java#supported-distributions

Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates.

Any reason not to use temurin? I don't have anything against zulu; I'm just wondering why we should ignore their recommendation. :)

Edit: also, please fill in the template properly.

[litetex]

I would also not recommend using zulu as already discussed in #6360

[XiangRongLin]

Also please write meaningful commit messages and PR titles.

Switched the GH action setup-java distribution to use Zulu

Does tell me what changed

Update to ci.yml

Does not

[geertjanw]

I would also not recommend using zulu as already discussed in #6360

AdoptOpenJDK does not exist anymore.

[triallax]

@geertjanw https://github.com/actions/setup-java#supported-distributions

Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore.

Indeed it does not exist anymore, but zulu is not the only alternative.

[geertjanw]

Well, here's one reason to use Zulu: if you had been using Zulu all along, instead of Adopt, you wouldn't now need to think about an alternative. You'd simply still be using Zulu, without any change needed, and your CI/CD pipeline would have continued on as normal. :-)

[triallax]

@geertjanw that's in the past. Who's to say the same argument couldn't have been applied if Zulu had been the discontinued distribution instead?

You'd simply still be using Zulu, without any change needed, and your CI/CD pipeline would have continued on as normal.

It's really not as big of a problem as you make it out to be. It's a three-line PR, whatever distribution we choose.

[geertjanw]

But the point is that Zulu isn't the discontinued distribution and it won't be either.

And, you're right, it isn't a big problem. However, make sure that all the JDK versions you need to test on, on all the operating systems you need to run on, are supported by the distribution you chose.

[carldea]

Also please write meaningful commit messages and PR titles.

Switched the GH action setup-java distribution to use Zulu

Does tell me what changed

Update to ci.yml

Does not
If you don’t mind I will do an amend to fix the comment.

[carldea]

https://github.com/actions/setup-java#supported-distributions

Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates.

Any reason not to use temurin? I don't have anything against zulu; I'm just wondering why we should ignore their recommendation. :)

No reason, to not use temurin, I can also add that too if you would like.

Edit: also, please fill in the template properly.

Will do.
Sorry about that.

[litetex]

@geertjanw

I'm getting kind of annoyed by this discussion as we had it already in #6360 but anyway here we go again:

AdoptOpenJDK does not exist anymore.

It does still exist: https://adoptopenjdk.net/
Also as mentioned in https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/

To ensure a smooth transition we will keep the AdoptOpenJDK website and the AdoptOpenJDK API active for some time to come, and we are retaining the old archived AdoptOpenJDK builds - though we recommend you always use the latest build in production which can now be found at adoptium.net/releases.

And it will also still exists for some time.
Also also: Eclipse temurin (the successor) is de-facto AoptOpenJDK Hotfspot just with another name.

---

Well, here's one reason to use Zulu: if you had been using Zulu all along, instead of Adopt, you wouldn't now need to think about an alternative. You'd simply still be using Zulu, without any change needed, and your CI/CD pipeline would have continued on as normal. :-)

That is an extremely weak argument. This can happen to everything... Maybe Azul Systems gets destroyed by a meteor, bankruptcy, ... tomorrow

---

But the point is that Zulu isn't the discontinued distribution and it won't be either.

... and it won't be either

Where is that written?
I didn't find anything in there Terms of use.

So please tell me what do you think is more likely to happen:

• That a single company product - who doesn't even let you view the source code of the distribution - is getting discontinued or
• That a open source project run by group of many collaborators with the support of at least 3 big companies is getting discontinued

[Redirion]

6360

as discussed there, we will use the logical successor of adopt.

Thank you for pointing out that adopt is now obsolete carldea!

[geertjanw]

Also also: Eclipse temurin (the successor) is de-facto AoptOpenJDK Hotfspot just with another name.

But that really isn't true. Check with the Eclipse Foundation, where Temurin, and not Adopt is found. Temurin, and not Adopt, is TCK licensed. They're totally different distributions.

[geertjanw]

Well, here's one reason to use Zulu: if you had been using Zulu all along, instead of Adopt, you wouldn't now need to think about an alternative. You'd simply still be using Zulu, without any change needed, and your CI/CD pipeline would have continued on as normal. :-)

That is an extremely weak argument. This can happen to everything... Maybe Azul Systems gets destroyed by a meteor, bankruptcy, ... tomorrow

But the point is that it hasn't. And all the places where Adopt is used now has the problem of needing to be updated, retested, etc, whereas Zulu has been consistent throughout, nothing changes for anyone making use of Zulu.