Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AdoptOpenJDK instead of Zulu in GitHub actions #6360

Merged

Conversation

litetex
Copy link
Member

@litetex litetex commented May 23, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Relies on the following changes

none

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@XiangRongLin XiangRongLin added the codequality Improvements to the codebase to improve the code quality label May 23, 2021
@XiangRongLin
Copy link
Collaborator

AdoptOpenJDK is unbranded (Zulu is branded)

What does that excatly mean?

@litetex
Copy link
Member Author

litetex commented May 25, 2021

I'm also not 100% sure what the author of https://dzone.com/articles/java-and-the-jdks-which-one-to-use meant, but I interpret that as

Also Azul states in https://www.azul.com/products/core/openjdk-terms-of-use/

Zulu Community is copyrighted software based on OpenJDK (http://openjdk.java.net/) and is 100% open source.

However no source code is publicly viewable, it has to be requested

@XiangRongLin XiangRongLin merged commit 4b27aec into TeamNewPipe:dev May 26, 2021
@litetex litetex deleted the used-adoptopenjdk-instead-of-zulu branch May 26, 2021 17:44
@TacoTheDank
Copy link
Member

Hmm I see, thanks for this change!

This was referenced Jun 5, 2021
@litetex litetex mentioned this pull request Aug 26, 2021
5 tasks
@geertjanw

This comment has been minimized.

@litetex litetex mentioned this pull request Aug 27, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants