Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gradle parameter to skip formatKtLint and use in CI #6858

Merged
merged 1 commit into from
Aug 7, 2021
Merged

Add gradle parameter to skip formatKtLint and use in CI #6858

merged 1 commit into from
Aug 7, 2021

Conversation

XiangRongLin
Copy link
Collaborator

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Add gradle parameter to skip formatKtLint and use in CI

Screenshots

with parameter

image

without parameter it starts with formatKtLint

image

Fixes the following issue(s)

  • This way runKtlint is not executed twice during CI

Due diligence

@XiangRongLin XiangRongLin added the CI Everything related to CI (Continuous integration) label Aug 6, 2021
litetex
litetex approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiangRongLin XiangRongLin merged commit c3b9465 into TeamNewPipe:dev Aug 7, 2021
@XiangRongLin XiangRongLin deleted the ci_ktlint branch August 7, 2021 10:36
@TobiGr TobiGr mentioned this pull request Aug 7, 2021
Closed
3 tasks
This was referenced Sep 5, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
CI Everything related to CI (Continuous integration)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XiangRongLin @litetex