Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in package name suffix through CLI #6420

Closed
3 tasks done
XiangRongLin opened this issue Jun 3, 2021 · 9 comments · Fixed by #7098
Closed
3 tasks done

Allow passing in package name suffix through CLI #6420

XiangRongLin opened this issue Jun 3, 2021 · 9 comments · Fixed by #7098
Labels
feature request Issue is related to a feature in the app meta Related to the project but not strictly to code

Comments

@XiangRongLin
Copy link
Collaborator

Checklist

Describe the feature you want

  • Allow specifying an optional package name suffix when calling ./gradlew assembleRelease --stacktrace
  • Similiar to how debug build have different package names

Is your feature request related to a problem? Please describe it

Additional context

How will you/everyone benefit from this feature?

  • Installation of both versions is possible
@XiangRongLin XiangRongLin added the feature request Issue is related to a feature in the app label Jun 3, 2021
@AudricV AudricV added the meta Related to the project but not strictly to code label Jun 3, 2021
@XiangRongLin
Copy link
Collaborator Author

@TobiGr Anything against this?

@XiangRongLin
Copy link
Collaborator Author

@Stypox maybe you can add some opinion on this, since TobiGr is not answering? I don't want to start working to only have it rejected later on

@Stypox
Copy link
Member

Stypox commented Aug 6, 2021

I don't see why not, it would just be a useful addition. Just make sure to document it well.

@TobiGr
Copy link
Member

TobiGr commented Aug 7, 2021

Sorry, I missed this ticket.
That sounds useful.
While you are at it, please also document the parameter added in #6858

@XiangRongLin
Copy link
Collaborator Author

How and where do you want to have it documented.

As for skipFormatKtLint I find the name very telling of what it is. The documentation i would do is "Skips the formatKtLint step" which is useless.

@Stypox
Copy link
Member

Stypox commented Aug 9, 2021

The documentation is more about "know that this is there", obviously its meaning is obvious

@opusforlife2
Copy link
Collaborator

As a rookie, I can tell you that when you see a method name like that which is fairly obvious but not commented, I would naturally see the obvious meaning, but then I would second-guess myself, "Is that really what it means? Maybe it's not actually that simple." and then check the related code anyway to confirm it.

A simple one line comment would help avoid that uncertainty.

@XiangRongLin
Copy link
Collaborator Author

The documentation is more about "know that this is there", obviously its meaning is obvious

Then again where should it be? There is currently is no documentation about all the custom gradle task like formatKtlint, runCheckstyle or runKtlint to which skipFormatKtlint could be added.


A simple one line comment would help avoid that uncertainty.

Where would that one line comment be then?

  1. If it's at the call site in the ci.yml, what should be done if there are other call sites, copy it over?
  2. If it's at the usage site inside the build.gradle then the comment is just duplicating the code

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Aug 9, 2021

I would go for 2, even if it duplicates the code. If a function isn't used immediately or very close by, then there should be a comment which prevents the user from going and looking for the usages.

Edit: At least, that's been my experience with navigating Newpipe's code with Ctrl+B in Android Studio and finding out that I'm completely lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants