-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing in package name suffix through CLI #6420
Comments
@TobiGr Anything against this? |
@Stypox maybe you can add some opinion on this, since TobiGr is not answering? I don't want to start working to only have it rejected later on |
I don't see why not, it would just be a useful addition. Just make sure to document it well. |
Sorry, I missed this ticket. |
How and where do you want to have it documented. As for |
The documentation is more about "know that this is there", obviously its meaning is obvious |
As a rookie, I can tell you that when you see a method name like that which is fairly obvious but not commented, I would naturally see the obvious meaning, but then I would second-guess myself, "Is that really what it means? Maybe it's not actually that simple." and then check the related code anyway to confirm it. A simple one line comment would help avoid that uncertainty. |
Then again where should it be? There is currently is no documentation about all the custom gradle task like
Where would that one line comment be then?
|
I would go for 2, even if it duplicates the code. If a function isn't used immediately or very close by, then there should be a comment which prevents the user from going and looking for the usages. Edit: At least, that's been my experience with navigating Newpipe's code with Ctrl+B in Android Studio and finding out that I'm completely lost. |
Checklist
Describe the feature you want
./gradlew assembleRelease --stacktrace
Is your feature request related to a problem? Please describe it
Additional context
How will you/everyone benefit from this feature?
The text was updated successfully, but these errors were encountered: