Fix channel item span count for SubscriptionFragment #6814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
force-pushed
the
channel-grid-span-count
branch
from
2399c72
to
6443961
Compare
TobiGr
added
bug
|
@desmonk could you test if this works? The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. |
4 tasks
|
The PR fixes the issue for the original author, see #6802 (comment). |
TobiGr
approved these changes
Aug 5, 2021
|
@TobiGr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
In #6705 I didn't notice that, when calculating the maximum number of grid list items that could fit horizontally, the
SubscriptionFragmentused a differentminWidththan the other list fragments. This is because all other list fragments containStreamInfoItems, while theSubscriptionFragmentcontainsChannelInfoItems. So I've created two methods to calculate the span count: one for streams (doing the same calculation as before) and one for channels.Before/After Screenshots/Screen Record
See the screenshots in #6802. This restores the correct pre-0.21.7 behaviour.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence