Fix grid span count calculation #6705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I checked. Its fixed |
|
Hmmm is this commit gonna fix the reordering of grids as you reload the feed? |
TobiGr
approved these changes
Jul 19, 2021
@Thewisem nope, it just fixes the text/thumbnail-too-big problems |
triallax
added
bug
|
Tested it out. Working ok |
Merged
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
shouldUseGridLayout()andgetGridSpanCount()intoThemeHelper. They were both duplicated in three classes:BaseLocalListFragment,FeedFragmentandSubscriptionFragmentand had a different (maybe wrong) implementation each time.getGridSpanCount(), instead of doing(int) Math.floor(screenWidth / ((float) minWidth)), I just doscreenWidth / minWidthsince the default integer division already yields the floor-ed result.Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
@onkq @Thewisem does this work for you?
Due diligence