Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bandcamp] Add Radio stream segments #6051

Merged
merged 1 commit into from
Apr 19, 2021
Merged

[Bandcamp] Add Radio stream segments #6051

merged 1 commit into from
Apr 19, 2021

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Apr 11, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Display channel / creator / artist name in stream segment list when available.

YouTube (no channel name) Bandcamp Radio (artist name)

Relies on the following changes

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@TobiGr TobiGr added feature request Issue is related to a feature in the app bandcamp Service, https://bandcamp.com/ labels Apr 11, 2021
fynngodau
fynngodau previously approved these changes Apr 11, 2021
Copy link
Member

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this one, too, and it works well. Please see my comments; other than that it looks good.

Display channel / creator / artist name when given
Copy link
Member

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review has been addressed 👍

@opusforlife2
Copy link
Collaborator

Will the heading still be "Chapters" on Bandcamp? What about something like "Streams", or "Tracks"?

@TobiGr
Copy link
Member Author

TobiGr commented Apr 19, 2021

@opusforlife2 I don't have time for that. Maybe someone else can do that. Please open an issue for that.

@TobiGr TobiGr merged commit 29bcf94 into dev Apr 19, 2021
@TobiGr TobiGr deleted the bandcamp_segments branch April 19, 2021 12:43
@opusforlife2
Copy link
Collaborator

Done. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bandcamp Service, https://bandcamp.com/ feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants