Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromecast support #351

Closed
wants to merge 4 commits into from
Closed

Conversation

KeizerDev
Copy link
Contributor

Hi,

I added Chromecast support today to the PlayVideoActivity.java! :)
Because I'm not in contact with the developers I don't really know where I should implement it else then that activity.
It's still very basic, (I've started with a very basic state enum but not implemented it).

This is what I have so far:

  • Cast videos.
  • Cast videos with metadata(title: Video title, subtitle: video url).
  • Play video notifications with working play, pause, delete buttons
  • Play video background on lock screen.
  • More metadata, thumbnail e.g.
  • State implementation, local or remote.
  • Stop the video playback, this is also a state thing.
  • Play/pause for player buttons support(should be implemented with the state)

Optional:

  • Make the volume buttons work with the Chromecast, now you can just click on the cast icon in the PlayVideoActivity.java

You can merge it to a new branch if you want to work on it together.
Again I would like to come in contact with you about the app because I'd like to implement some more cool stuff :) @theScrabi


Ps. It is really a deal now to use this app because it supports the Chromecast Audio and the official app does not 👍

@KeizerDev KeizerDev mentioned this pull request Aug 23, 2016
@theScrabi
Copy link
Member

I'm on vacation right now. Please wait until next week ;)

@theScrabi
Copy link
Member

But one thing I can tell you so far is, that you would not get this through. Newpipe is Free Software, and strictly follows the f-droid restrictions since its the official distribution way. Therefore having gsm core as a library within NP is unacceptable.

I'm sorry, but unless you do something via UPnP you would not be able to bring cromecast support into fdroid NewPipe

@theScrabi theScrabi closed this Sep 11, 2016
@KeizerDev
Copy link
Contributor Author

@theScrabi It would be the only reason to use this, the official Youtube app doesn't support the Chromecast Audio and mine implementation does. I think it would be a huge opportunity, but it's up to you to decide.

@theScrabi
Copy link
Member

theScrabi commented Sep 12, 2016

I'm sorry, still no.
Please read the commend above. If there is an opensource library for supporting chromecast, we could talk about that.

It's because of this and this.

NewPipe is google FREE!!! And that should remain that way.

@KeizerDev
Copy link
Contributor Author

@theScrabi https://github.com/DroidsOnRoids/Casty, let's implement this!

@theScrabi
Copy link
Member

theScrabi commented Mar 27, 2017

All right +1 great :)
I'm realy looking forward to this :)

@coffeemakr coffeemakr mentioned this pull request Sep 3, 2017
@theScrabi theScrabi reopened this Sep 3, 2017
@theScrabi theScrabi closed this Sep 3, 2017
@Echolon
Copy link

Echolon commented Feb 21, 2019

Any updates on chromecast?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants