Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshots #10213

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Update screenshots #10213

merged 4 commits into from
Jul 8, 2023

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jul 6, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

I used #9182 to take screenshots, so that they don't become outdated when we release 0.26.0. The screenshots resemble the previous screenshots, except that they are all the same size (16:9), they try to show off as much public domain material as possible, and there are no screenshots for Downloads.

All images have been stripped of metadata and optimized with both mogrify -strip -taint -compress Lossless and optipng.

You can view a preview here.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added the meta Related to the project but not strictly to code label Jul 6, 2023
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can you add one screenshot using the light theme on a phone, too? Maybe take one screenshot twice so the difference is clearly visible. You could also make sure to display the two tablet screenshots in the same line by adding an extra lilnebreak after the last phone screenshot.

What about the translated READMEs? Do we need to modify their image URLs, too?

@Stypox
Copy link
Member Author

Stypox commented Jul 7, 2023

@TobiGr I have changed the "phone search" screenshot to be white-themed, and the "tablet search" one to be dark-themed. I think the difference between dark and light themes is clear enough without duplicating screenshots, which would result in more used space. I added two <br/><br/> between the tablet and phone images. I also updated all translated READMEs.

@TobiGr TobiGr merged commit 62ce0b0 into TeamNewPipe:dev Jul 8, 2023
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants