Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant inconsistent display for playback information in VideoDetailFragment #8176

Closed
4 tasks done
Trust04zh opened this issue Apr 11, 2022 · 0 comments · Fixed by #8180
Closed
4 tasks done

Instant inconsistent display for playback information in VideoDetailFragment #8176

Trust04zh opened this issue Apr 11, 2022 · 0 comments · Fixed by #8180
Labels
bug Issue is related to a bug

Comments

@Trust04zh
Copy link
Contributor

Trust04zh commented Apr 11, 2022

Checklist

  • [] I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

dev, lastest commit till opening this issue

Steps to reproduce the bug

  1. enable Resume playback option in History and cache.
  2. open a video A and watch for a while (or seek to somewhere in the video).
  3. open a video B and watch for a while (or seek to somewhere in the video).
  4. press system back button, it displays the detailed thumbnail for A, while it displays the playback information (relevant views are position_view and detailed_position_view) for B for an instant, then display for A.

Expected behavior

keeps displaying playback information for A.

Actual behavior

at first displays playback information for B for a while.

Screenshots/Screen recordings

video_2022-04-11_23-42-39.mp4

Logs

No response

Affected Android/Custom ROM version

Android 10 / Minu 12

Affected device model

Redmi k30i

Additional information

I would fix this together with #4053, where I'm to make sure the display of position_view and detailed_position_view are controlled by relevant user setting, trivial though, not fixing this also makes the setting function kinda inconsistent. Please reply if this shouldn't be considered as bug.

0.22.1 (via github)(latest version) has no this problem, it has different behavior that it displays thumbnail for B instead of A when press system back button.

@Trust04zh Trust04zh added the bug Issue is related to a bug label Apr 11, 2022
Trust04zh added a commit to Trust04zh/NewPipe that referenced this issue Apr 12, 2022
Trust04zh added a commit to Trust04zh/NewPipe that referenced this issue Apr 18, 2022
@Stypox Stypox closed this as completed in e947e86 Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant