Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History settings toggles have misconfigured functionality #4053

Closed
opusforlife2 opened this issue Aug 2, 2020 · 2 comments · Fixed by #8180
Closed

History settings toggles have misconfigured functionality #4053

opusforlife2 opened this issue Aug 2, 2020 · 2 comments · Fixed by #8180
Assignees
Labels
bug Issue is related to a bug

Comments

@opusforlife2
Copy link
Collaborator

Version

  • 0.19.8 (and dev branch)

Steps to reproduce the bug

  1. Enable Watch history. Ensure Resume playback and Positions in lists are disabled (in 0.19.8 Positions in lists is automatically greyed out).
  2. Play a few videos from the same list.
  3. Reopen that list.

Expected behavior

You don't see playback positions in the list.

Actual behaviour

You can see playback positions in the list

This is clearly a bug because Watch history has the Positions in lists functionality built in somehow. Moreover, as @avently says, in 0.19.8, Positions in lists is just a dummy toggle that doesn't do anything. In the dev branch it currently has a single function that is specific to the unified player backstack.

So these two toggles currently mislead users. At least Resume playback does what it says.

The solution for this bug is that the Positions in lists toggle should regain its original function, and Watch history should lose the (same) extra function.

@opusforlife2 opusforlife2 added the bug Issue is related to a bug label Aug 2, 2020
@avently
Copy link
Contributor

avently commented Aug 2, 2020

This is the last usage of the setting that should control "position in list" toggle:
https://github.com/TeamNewPipe/NewPipe/pull/2517/files#diff-5b97b6c787e8fbad31d373380daed5aeL175

Just for the reference for future contributors.

@Trust04zh
Copy link
Contributor

I would work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants