Always show the full screen button

[nbmrjuhneibkr]

Checklist

• I checked, but didn't find any duplicates of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one feature request. I will open one issue for every feature I want to request.

Describe the feature you want

In v0.20, full screen button is hidden when automatic screen rotation is enabled in the OS.
The button should always be accessible, regardless of the system settings.

Is your feature request related to a problem? Please describe it

When the device lies on any flat surface and auto-rotate is enabled in the OS, there is no way to play videos in full screen mode without picking the device up to trigger the sensor, or disabling auto-rotate.

How will you/everyone benefit from this feature?

A user may want to watch videos without picking the device up. Disabling auto-rotation globally is not an acceptable solution.

Additional context

When combined with the manual video rotation control (which should also be restored), this will restore all manual controls that were available in NewPipe before the 0.20 update.

[avently]

I disagree with the issue. Your example with flat surface is like "I need to say something related to the issue".
I can agree with some of your arguments related to fullscreen button in case of locked orientation but not unlocked.
Whenever I see disappeared fullscreen button it is a sign of enabled autorotation. And I'm 100% sure that I can rotate the device and get whatever orientation I want. With always shown button I need to use it or always look at status bar's panel (which is not an option on android 4.4 because the autorotation button isn't present there). This is something I know usefulness of.

[nbmrjuhneibkr]

I disagree with your disagreement. Your responses often look like "I need to find a reason to dismiss this issue".

Sometimes I keep my phone on a table and play YouTube videos on it while doing work. I didn't have to pick up the phone to change the orientation before v0.20.
Please stop forcing your personal usage scenarios on everyone else.

With always shown button I need to use it or always look at status bar's panel (which is not an option on android 4.4 because the autorotation button isn't present there).

Then why not have two slightly different icons for the button? This is an easy fix.

[avently]

@nbmrjuhneibkr

Please stop forcing your personal usage scenarios on everyone else.

Please stop saying what I should do and I will not say where you need to go.

[nbmrjuhneibkr]

I'm only mentioning things that have direct impact on the app and the way people use it.

and I will not say where you need to go.

And it looks like you're one step away from taking the route of personal attacks.

Anyway, back to the issue. If someone is going implement this while addressing the "how do I know if auto-rotate is enabled" thing, my idea would be to have a normal full screen button when it's disabled, and the button with added circular arrows either on the outside or on the inside when it's enabled.

[avently]

@nbmrjuhneibkr

And it looks like you're one step away from taking the route of personal attacks.

It looks like you like to call things in other words which aren't near truth. Even now you provoking.

I'm not interested in talking about people when developing the app. It's counterproductive. Instead I prefer to talk about real app's issues. So if you like this correct route we can follow it.

[nbmrjuhneibkr]

While @avently was busy writing a comment about the interest (or lack thereof) in talking about people, I came up with an easier solution for #4478 (comment)
Instead of designing new icon for the full screen button, just change the color of the button when auto-rotation is enabled. Simple.

[hipunk]

"I", "I", "I"... Does this guy talk about anything else than himself or what he thinks?
Isn't this a community project of more than 500 contributors? Why is avently allowed to remove so many features when he's this clueless about smartphones? (e.g. #4414: never heard of GPRS. Doesn't know multiple WiFis might have different throughput. Thinks android phones have tablet UIs. Confuses accessibility settings with build.prop DPI flags. Thinks every device in the world is held using hands and can be rotated. Makes fun of the concept of reducing traffic, although it increases battery runtime like almost nothing else in a smartphone)

How is one single person allowed to introduce so much breakage?
Let me rephrase: Avently is deleting functional, proven and real world tested work of others! Stop him already! 0.20.0 is unusable, yes, useless, on a Samsung Galaxy S4. He said we can blame him because he is responsible. Here is the blaming, stop breaking stuff for no gains, avently.

[nbmrjuhneibkr]

@avently

how old are you?

This provocateur is done.

I thought we were going to stop talking about people here...

Here's another reason for implementing this (or rather fixing, since this wasn't an issue before 0.20), if I haven't given enough reasons already: feature parity with the official YouTube app. This feature is present there, probably for the same exact reason as the one I mentioned. NewPipe losing features that are present in the official client is not a step in the right direction.

[avently]

@nbmrjuhneibkr

feature parity with the official YouTube app

I'm not interested in feature-parity with YouTube app. This can't be a goal. YouTube app doing something great and something bad. In this case showing a button to rotate orientation when it's unlocked globally is bad behavior because if a user chose to autorotate his screen's orientation it means he likes this behaviour. Forcing rotation by a button it's a step in a wrong direction in this case.

[nbmrjuhneibkr]

YouTube app doing something great and something bad.

This feature adds more choice and doesn't break anything. Definitely not a "bad" feature. Better than some that have been implemented, arguably.

if a user chose to autorotate his screen's orientation it means he likes this behaviour

As I already said, auto-rotation doesn't work in a use case described in this issue, but user may still want to keep it enabled globally for other use cases. There should be a manual override for this in the app.

Forcing rotation by a button it's a step in a wrong direction in this case.

The app isn't forcing anything, the user does. This is user choice that doesn't exist anymore in v0.20. Removal of this feature didn't make NewPipe more useful, that's for sure.

[stnby]

Omg please keep the full screen button rotating screen doesn't even put it in full screen this is so annoying.

[opusforlife2]

Reply to #4500 (comment)

@avently I suspect there may be a strong overlap between users who want the full screen button even with unlocked rotation, and users who want automatic full screen on tapping the thumbnail. So we should wait for more information.

[avently]

@opusforlife2 what information you want to get?

[opusforlife2]

If everyone involved is satisfied with automatic full screen behaviour then we won't need this feature anyway. If not, it could be discussed further.

[nbmrjuhneibkr]

I don't see how automatic full screen player could be a replacement for this feature request.

#4152 aims to restore (as an option, I think) v0.19 behavior where videos played only in full screen, while this issue is about expanding current behavior of the player by displaying the full screen button (perhaps a slightly different-looking - #4478 (comment) ) when automatic screen rotation is enabled in the OS.

[nahuhh]

Gotta agree with op..
Need to force rotation.

I want my videos to STAY in landscape, not flip to portrait when I move

Seems like it was more work than it was worth to make the icon hide based on the device orientation toggle..

Thanks. Been using the app for years and it's great. The new ui looks good and I like the direction. But it's not usable.

Background play and current queue management is pretty much gone? (Compared to older versions)
Old version was a solid "1.1"
This feels like a super alpha pre2.0 release.

[nbmrjuhneibkr]

force rotation

That's a different issue: #4500

And maybe also related to this, depending on personal preference: #4152

This one is only about the full screen button (which doesn't necessarily lead to video rotation) currently being hidden when auto-rotation is enabled in the OS.

[iamthesenate1]

I think this should be an optional setting, not enabled by default (becouse it looks like some users don't agree), but the ones who want it be able to enable it. After all I think that having the choice is the important thing here

[nbmrjuhneibkr]

After all I think that having the choice is the important thing here

I feel that removing as much choice as possible and leaving users with only one "correct" way to use NewPipe was one of the main goals of v0.20 development, sadly.

[triallax]

I want to work on this, but it's been suggested that I should ask for people's opinions through a poll first, so here I am. Vote by reacting with the emoji beside the option you vote for (e.g. 🎉 for 2). If I forgot any option, feel free to make a comment.

1. 👍 Always show the full screen button (without option to disable this)
2. 🎉 Hide when auto-rotation is enabled, which is the current behavior (also without an option to disable this)
3. Add an option to choose between the two behaviors
   1. ❤️ Make 1 the default option
   2. 👀 Make 2 the default option

Somewhat related: @Redirion suggested creating a "fullscreen control" setting, which in addition to the previous options has an "always play videos in fullscreen" option. The only issue I see with this idea though is that that option is not mutually exclusive with the others (e.g. if you leave fullscreen while auto-rotation is enabled, which behavior do we assume?).

@TobiGr @opusforlife2 @B0pol @TiA4f8R @vkay94 @TacoTheDank @XiangRongLin @MD77MD @s1awek @shivasagarrao @wilzbach @T5000 @Bruceforce @ShareASmile @89z @thinsoldier @atmosfar @SameenAhnaf

Note: if you don't want to be mentioned by polls in the future, please react with 🚀.

[Bruceforce]

STOP SPAMMING THE THREAD. this is the third time I've gotten an email for a dumb vote request.

Just make a comment and people will see it if they are subscribed. Don't at mention every single person in the thread.

Why don't you just react with the 🚀 emoji then like suggested in the notes? At least you currently have not done so in this thread.

[triallax]

People, PLEASE stop posting comments that just ask for this to be added. If you have no value to add to the discussion, don't make a comment. Just do a +1 reaction.

[tguen]

Let me repeat a bit from my duplicate report to explain why this feature is bad UX.

1. I have enabled the "sensors off" quick tile from developer settings, which disables the gyro sensor. This effectively disables auto-rotate without the app detecting that it's disabled, so simply detecting when it's enabled is inadequate. The app doesn't explain why the button hidden. I was frustrated for about 2 weeks because it disappeared and I couldn't figure out why. I downgraded the app and it was still missing. I only figured out why when I came here to report it as a bug and found a comment on another report that explains why it disappeared.

2. Suppose I want to watch a video in fullscreen while laying on my side. If I enable auto-rotate while laying down, it doesn't switch to fullscreen. If I rotate to landscape, then disable auto-rotate, it automatically exits fullscreen to switch to portrait mode.

After 6 months of voting, it seems only 1 of 12 people think it should stay the way it is. (That one person clearly has a toxic attitude that should make you consider whether you want them involved with your project.) Due to the above issues, I think the way it is shouldn't even be the default option even if the app explains the feature to the user so they are at least aware that they can dig through the settings menu for a way to show a button needed to resolve them. It's too big of a problem to justify hiding the button for a "cleaner UI".

[T5000]

Thank you for the write-up, @tguen. I have to say I have been following this for over 6 months now and I completely agree with everything you have written. The toxic attitude is just bad and should not be tolerated.

[goyalyashpal]

copying over my input from #4500 as mentioned in #4500 (comment)

---

i hadnt read the whole details and discussion that went here. jusst saying the problem i was facing for quite time:

a similar issue is the full screen button is not available when screen rotate is on. it becomes sensor dependent then which is kinda frustrating. the suggestion is to have the full screen button there even when system orientation is not locked/free.

Originally posted by @yashpalgoyal1304 in #4500 (comment)

---

Just click on the full screen button: (the button which looks like this [ ] next to 25:29)
@B0pol at #4500 (comment)

the problem is there itself. that full screen button is not available when "auto rotate" is ON. see following screenshots:

auto rotate = on	auto-rotate = off

auto rotate = on
auto rotate = off

Originally posted by @yashpalgoyal1304 in #4500 (comment)

[goyalyashpal]

i guess #5713 says smth similar

[LeonTheOriginal]

One additional major drawback of the missing full screen switch is that there seems to be no way to view the comments or video description in landscape mode without pausing playback or rotating the device, which can be very inconvenient when using a stand or the device is lying flat on a table.
At least in current versions of the app, this issue also only affects landscape format videos. Portrait/Vertical videos always offer a full screen toggle, as well as tablet mode. Through this it seems inconsistent that only the probably most common standard scenario (landscape video, tablet mode disabled, screen rotation unlocked) disables the full screen switch and it should be no problem to also add that button in this case as it is already visible in all other possible cases.

[opusforlife2]

@LeonTheOriginal Long-press on the top-right arrow.

[LeonTheOriginal]

@opusforlife2 Thanks for the info. I didn't know that there is a long press action for that botton which is pretty counterintuitive for an icon to open/close a submenu.

[qol3m]

I need this, too.
Whether I disabled the sensors,
whether gravity does not align with my viewing angle (surely you have been on your side in bed before??),
whether I turned rotate off so that it does not rotate other apps when i switch,
or whether the sensor is broken/flawed,

I have been missing this many times.

[goyalyashpal]

ping

[ccuser44]

THIS IS AN ABSOLUTE MUST!

Its horribly annoying that this is not a feature. Furthermore if you have the phones gyroscope disabled the full screen button wont show at all

[Stypox]

@ccuser44 @tguen could you verify that #9693 always shows the fullscreen button, since you don't have an accelerometer for rotation?

[goyalyashpal]

as there's still lack of consensus on impact of implementing this with option , how about taking a leap of faith... and shipping this implemented anyhow...

• with lack of it, those who want it are saying here.
• if the new behaviour causes disturbance, then those ppl will say too (like they did in v0.20 release and all other times too)

that will settle it automatically... rather than just hypothesizing about the percieved dislike of the feature, how about testing in wild now....

and... i am not saying to do wild burning things in this manner, this is pretty small harmless change, so, this testing by releasing and looking for public reaction is feasible here.

[AudricV]

Once again the open source community has shown their immeasurable incompetence.

No, because we will implement the first option, before the player rewrite (the one which won this poll and the easiest one to implement).

Thanks for being agressive against contributors and team members who work on this project in their free time.