Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnify button to change layout from straight to landscape #10509

Closed
6 tasks done
joe61fa6f1awe opened this issue Oct 24, 2023 · 2 comments
Closed
6 tasks done

Magnify button to change layout from straight to landscape #10509

joe61fa6f1awe opened this issue Oct 24, 2023 · 2 comments
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)

Comments

@joe61fa6f1awe
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

I noticed that the video-playing activity can add one more feature which is a magnify button to change the layout from straight to landscape, which means change the video to full screen.

Why do you want this feature?

Not too many problems or limitations.
I'm a student at the Australian National University. I have one course that asks us to write a feature, Junit test, or debug for Open Repo on GitHub. I read the contribution. md and I know you don't want a new feature in the current development phase. Therefore, I don't expect the PR will be accepted. However, we have to write a repo according to this development (No matter whether the PR is accepted or not, we have to at least publish a PR and receive the developer's reply.) Therefore, I still wish you can let me open this issue to finish my assignment, which is really close to due time.

Additional information

No

@joe61fa6f1awe joe61fa6f1awe added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 24, 2023
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Oct 24, 2023

Duplicate of #4478

Regarding the dev's reply part, I'll let one of the other devs will let you know as I myself am not available for reviewing PRs. Please let us know your due submission date.

@SameenAhnaf SameenAhnaf added template ignored The user didn't follow the template/instructions (or removed them) duplicate Issue or discussion is a duplicate of an existing issue or discussion and removed feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 24, 2023
@joe61fa6f1awe
Copy link
Author

I'm due at this weekend 11:59 p.m.
I'm glad you replied to me and I will also move to the issue you provide.

@joe61fa6f1awe joe61fa6f1awe mentioned this issue Oct 29, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

No branches or pull requests

2 participants