Skip to content

Conversation

@JinUng41
Copy link
Collaborator

@JinUng41 JinUng41 commented Jun 4, 2025

👻 PULL REQUEST

📄 작업 내용

  • 홈 화면에서 새로운 글 작성 후 다시 돌아왔을 때 최상단으로 올라갈 수 있도록 구현하였습니다.
  • 프로그레스바의 애니메이션이 동작하지 않았던 문제를 해결하였습니다.

📚 참고자료

  • 기억합시다! 프로그레스는 0~1 사이의 Float 값만 가능하다는 것을,,

🔗 연결된 이슈

Summary by CodeRabbit

  • New Features

    • After completing a post, the home feed now automatically scrolls to the top for easier viewing of new content.
  • Enhancements

    • Progress bars in community and profile sections now update with a smoother, delayed animation for improved visual feedback.
    • Community feed updates are more efficient, preventing unnecessary UI refreshes when there are no changes.

@JinUng41 JinUng41 requested a review from youz2me June 4, 2025 14:21
@JinUng41 JinUng41 self-assigned this Jun 4, 2025
@JinUng41 JinUng41 added 🛠️ fix 기능적 버그나 오류 해결 시 사용 🍻 진웅 술 한잔 가온나~ labels Jun 4, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jun 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update modifies progress bar animations in community and profile views by introducing delayed, animated updates. It also ensures that after posting in the Home view, the collection view scrolls to the top. Minor adjustments include improved duplicate filtering in community item bindings and additional debug logging.

Changes

File(s) Change Summary
.../Community/View/Cell/CommunityInviteCell.swift
.../Profile/Component/ProfileInfoCell.swift
Changed progress bar updates to use delayed, animated transitions for smoother UI animation.
.../Community/View/CommunityViewController.swift Modified progress calculation for cell configuration; added duplicate filtering and debug logging.
.../Home/View/HomeViewController.swift Added closure to scroll collection view to top after post completion.
.../Home/View/WritePostViewController.swift Added onPostCompleted closure and invoked it after successful post; changed cancelBag to constant.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeViewController
    participant WritePostViewController

    User->>HomeViewController: Tap "+" (plusButtonDidTap)
    HomeViewController->>WritePostViewController: Present for new post
    User->>WritePostViewController: Complete post
    WritePostViewController->>WritePostViewController: onPostCompleted?()
    WritePostViewController->>HomeViewController: onPostCompleted triggers scrollToTop()
    HomeViewController->>HomeViewController: Scroll collection view to top
Loading
sequenceDiagram
    participant CommunityViewController
    participant CommunityInviteCell

    CommunityViewController->>CommunityInviteCell: configure(progress)
    Note right of CommunityInviteCell: After 0.3s delay<br>setProgress(progress, animated: true)
Loading

Assessment against linked issues

Objective Addressed Explanation
Home: Scroll to top after new post (#226)
Animate progress bars in profile and community views (#226)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

Poem

A bunny taps and scrolls with glee,
Progress bars now animate, see!
Post a note, then hop to the top,
With smooth new flows that never stop.
Community and profile shine anew—
Hopping forward, just for you!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dc7eba and 10b20d0.

📒 Files selected for processing (5)
  • Wable-iOS/Presentation/Community/View/Cell/CommunityInviteCell.swift (3 hunks)
  • Wable-iOS/Presentation/Community/View/CommunityViewController.swift (2 hunks)
  • Wable-iOS/Presentation/Home/View/HomeViewController.swift (1 hunks)
  • Wable-iOS/Presentation/Home/View/WritePostViewController.swift (2 hunks)
  • Wable-iOS/Presentation/Profile/Component/ProfileInfoCell.swift (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@youz2me youz2me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. 당신은 천재입니까?

@github-project-automation github-project-automation bot moved this to In Review in Wable-iOS Jun 4, 2025
@JinUng41 JinUng41 merged commit 28e1e5d into develop Jun 4, 2025
1 check was pending
@github-project-automation github-project-automation bot moved this from In Review to Done in Wable-iOS Jun 4, 2025
@JinUng41 JinUng41 deleted the fix/#226-ui-animation branch June 4, 2025 14:23
youz2me pushed a commit that referenced this pull request Oct 26, 2025
[Fix] 기타 UI Animation 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍻 진웅 술 한잔 가온나~ 🛠️ fix 기능적 버그나 오류 해결 시 사용

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Fix] 기타 UI 동작 수정

3 participants