[Fix] 커뮤니티 사전 신청 풀리는 문제 해결 및 UI 개선 #172
Conversation
WalkthroughThis update corrects a property name typo from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CommunityViewController
participant CollectionView
User->>CommunityViewController: Complete community registration
CommunityViewController->>CommunityViewController: scrollToTopItem()
CommunityViewController->>CollectionView: Scroll to item at (0,0) with animation
CommunityViewController->>CommunityViewController: Show registration completion sheet
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
JinUng41
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Wable-iOS/Infra/Network/DTO/Response/Community/IsUserRegistered.swift (1)
14-18: Good work fixing the DTO structure!This change properly fixes the typo in the property name from
commnunityNametocommunityNameand adds theCodingKeysenum to map the JSON key "community" to the Swift property. This ensures correct decoding of the network response.The original issue was likely silent because optional properties don't trigger decoding errors when missing - they just become nil, as you noted in your PR description.
Consider adding a unit test that verifies this specific decoding behavior to catch similar issues in the future.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
Wable-iOS/Data/Mapper/CommunityMapper.swift(1 hunks)Wable-iOS/Infra/Network/DTO/Response/Community/IsUserRegistered.swift(1 hunks)Wable-iOS/Presentation/Community/View/Cell/CommunityInviteCell.swift(1 hunks)Wable-iOS/Presentation/Community/View/CommunityViewController.swift(2 hunks)
🔇 Additional comments (4)
Wable-iOS/Presentation/Community/View/Cell/CommunityInviteCell.swift (1)
71-71: Good UI improvement!Disabling animation during the progress bar update in the
configuremethod is a sound decision. This prevents unnecessary visual transitions when initially setting up the cell, making the UI feel more responsive and stable.Wable-iOS/Data/Mapper/CommunityMapper.swift (1)
26-26: Critical typo fix!Fixed the property name from
commnunityNametocommunityName, which addresses the root cause of issue #171 where pre-registration information wasn't persisting after app restart. This ensures proper data mapping from DTO to domain model.Wable-iOS/Presentation/Community/View/CommunityViewController.swift (2)
172-172: Nice UX enhancement!Adding the scroll to top behavior after registration completion is a good UX improvement. This ensures users can immediately see their registered community at the top of the list.
251-260: Robust implementation with proper guardsThe
scrollToTopItem()method is well-implemented with appropriate guards to check if sections and items exist before attempting to scroll. The animation makes for a smooth user experience.
youz2me
left a comment
youz2me
left a comment
There was a problem hiding this comment.
고생하셨습니다! 오타였다니 마음이 아프네요...
옵셔널 값에 대한 오류 처리 방법은 사실 잘 생각이 나지 않네요... 다만 기능 구현에 앞서 유닛 테스트를 해볼 수 있다면 좋을 것 같습니다. 저도 이번에 기능 구현하면서 생각보다 이미 구현해놨던 부분에 오류가 많이 생겨서 시간을 많이 잡아먹었는데... 먼저 테스트를 진행했다면 이런 일이 없지 않았을까 싶더라구요.
모든 구현이 끝나면 테스트에 대해 같이 공부해봐도 좋을 것 같습니다 ~! 고생하셨습니닷
[Fix] 커뮤니티 사전 신청 풀리는 문제 해결 및 UI 개선
👻 PULL REQUEST
📄 작업 내용
👀 기타 더 이야기해볼 점
nil로 할당되었었더라고요. 이것을 해결할 수 있는 방법이 있을지 궁금합니다.🔗 연결된 이슈
Summary by CodeRabbit