Skip to content

Do not whitelist json keys for get_strex_transaction server reponse #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HansOlavS merged 1 commit into from
Feb 13, 2019
Merged

Do not whitelist json keys for get_strex_transaction server reponse #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion target365_sdk/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ def get_strex_transaction(self, transaction_id):
response = self.client.get(self.STREX_TRANSACTIONS + '/' + transaction_id)
response.raise_for_status()

return StrexTransaction(**response.json())
return StrexTransaction(validate_keys=False, **response.json())

def delete_strex_transaction(self, transaction_id):
"""
Expand Down
4 changes: 2 additions & 2 deletions target365_sdk/models/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class Model:
__metaclass__ = ABCMeta

def __init__(self, **kwargs):
def __init__(self, validate_keys=True, **kwargs):

args = self._init_preprocess(kwargs)

Expand All @@ -12,7 +12,7 @@ def __init__(self, **kwargs):

for key, value in args.items():

if key not in self._accepted_params():
if validate_keys and key not in self._accepted_params():
raise Exception('This model does not allow parameter `' + key + '`')

setattr(self, key, value)
Expand Down