Do not whitelist json keys for get_strex_transaction server reponse #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SDK validates all keys in the server response against a whitelist in the model. This makes sense for input from the user - to give useful errors when the SDK is used incorrectly, but validating the server response like this makes it hard to add more information to the server response in the future without breaking existing clients.
This has already happened, which is why I created this fix (for example, eTag is now returned, and rejected by the model, so get_transaction does not work currently).
This change still uses the whitelist by default, but turns it off when returning data from get_strex_transaction.
(It probably needs to be done to other server responses as well, but I don't want to modify code I don't use/test).