Skip to content

fix(react-router): fix path param handling with relative navigation #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

fix(react-router): fix path param handling with relative navigation #3423

merged 2 commits into from
Feb 13, 2025

Conversation

schiller-manuel
Copy link
Contributor

fixes #2415
fixes #2801

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 13, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 76f5972.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 36s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 28s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-13 18:38:50 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 13, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3423

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3423

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3423

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3423

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3423

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3423

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3423

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3423

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3423

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3423

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3423

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3423

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3423

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3423

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3423

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3423

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3423

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3423

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3423

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3423

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3423

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3423

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3423

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3423

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3423

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3423

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3423

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3423

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3423

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3423

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3423

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3423

commit: 76f5972

@schiller-manuel schiller-manuel merged commit b8165ab into main Feb 13, 2025
5 checks passed
@schiller-manuel schiller-manuel deleted the fix-relative-path-params branch February 13, 2025 18:39
birkskyum added a commit to birkskyum/router that referenced this pull request Feb 17, 2025
@birkskyum
port TanStack#3423 from react-router
91b4a5b
birkskyum added a commit to birkskyum/router that referenced this pull request Feb 18, 2025
@birkskyum
port TanStack#3423 from react-router
6c7341f
birkskyum added a commit to birkskyum/router that referenced this pull request Feb 19, 2025
@birkskyum
port TanStack#3423 from react-router
d9eb1f4
schiller-manuel pushed a commit that referenced this pull request Feb 20, 2025
@birkskyum @autofix-ci
@brenelz @SeanCassiere
feat(solid-router): Add a SolidJS driver for TanStack Router (#3276)
ad20a68 
* copy react-router

* update

* Move forward branch

* cleanup

* cleanup

* add publish

* bump deps

* ci: apply automated fixes

* remove unused imports

* ci: apply automated fixes

* bump  vite plugin solid

* fix imports

* ci: apply automated fixes

* remove react lint from solid-router

* fix types

* ci: apply automated fixes

* add structuralSharing

* downgrade vite plugin solid

* fix scroll-restoration in solid-router

* fix Transitioner

* fix imports from ScrollRestoration

* Fix tests

* Fix more tests

* Remove the react $$typeof

* add accessors to useLocation

* add remountDeps

* cleanup

* remove tanstack/store

* format

* add missing call to setupScrollRestoration

* format

* add optional

* align match component

* make matches a signal

* Bump vite-plugin-solid to stable

* add missing await

* Fix unknown error

* Tweak the tests to call functions

* remove unused vars

* fix lockfile

* Down to 25 failures

* Remove .only

* call search()

* remove the structuralSharing

* fix type test

* fix structuralSharing

* comment out structured sharing validation check

* fix typings

* comment out serialization check

* comment out serialization check

* cleanup

* improve types of useSearch

* fix "when setting search params with 2 parallel navigate calls"

* fix useParams

* fix types

* fix useParams types

* cleanup debug

* fix link data loader

* fix data loader signal

* fix type test

* fix Link "when navigating away from a route with a loader that errors"

* setup on() simpler

* make initial load a createRenderEffect

* Fix some link preload tests

* add accessor to UseMatchRoute

* fix: when navigating to /posts with a beforeLoad that returns context

* call parentRouteId

* re-enable invariant

* fix when navigating from /invoices to ./invoiceId and the current route is /posts/$postId/details

* use memo for prev

* remove browserhistory  workaround

* fix  "after a navigation, should have emitted the "onResolved" event twice"

* skip remount

* add types to useSearch

* fix search middleware

* don't need a getter

* sync react-router

* solid kitchen sink

* add the example to workspace

* lockfile

* fix solid kitchensink name

* add solid template

* fix example

* rename react to solid

* work on example

* add accessor

* fix type tests

* Fix login in example

* Don't destructure

* Fix stuck on pending component

* Fix where loaderData can be undefined

* Use For component

* More refactor

* Hacky way to fix loading spinner

* Fix one test

* Better MatchRoute fix

* Down to 1 failing test

* Fix last test

* cleanup subscription

* lockfile

* eslint

* ci: apply automated fixes

* fix router-core lint

* ci: apply automated fixes

* add e2e test for solid-router

* ci: apply automated fixes

* work on solid-router e2e suites

* fix comment

* use solid-virtualizer

* work on scroll-restauration

* work on scroll-restauration

* skip react-specific useRenderEffect test

* fix errorcomponent being used before it's defined

* set solid target for esbuild

* ci: apply automated fixes

* fix rspack tests

* fix query tets

* add solid-query example

* use memo for post

* add memo for posts

* fix example

* add jsx compiler flags to esbuild commands

* add esbuild-plugin-solid

* Fix some e2e

* ci: apply automated fixes

* port #3423 from react-router

* fix useLoaderData test-d

* add codeSplitGroupings

* Scroll restoration fixes

* add asset headcontent script

* remove solid-router-copy

* fix react use

* fix scroll restoration test

* skip esbuild because it's broken in react-router

* wait for timeout

* update scroll-restoration to match react

* useLocation

* use on() in match

* align useNavigate with react-router

* lockfile

* fix Scripts test

* align __TSR_SSR__ in ScriptOnce

* remove solid-router from publish

* lint

* ci: apply automated fixes

* align to react-router

* port over "exclude props from state equality check to prevent history push for equal url and state"

* align with react-router

* add shouldThrow

* fix typePrimitives

* use searchStr to fix the search middleware

* ci: add solid-router to the labeler

* use patched vite-plugin-solid

* eslint

* ci: apply automated fixes

* use vite-plugin-solid 2.11.2

* remove only modifier

* move vite-plugin-solid peerDep to router-plugin

* use latest vite-plugin-solid

* move vitest to root

* bump vitest

* revert onRendered

* lint

* add to publish

* fix scroll restoration

* ci: apply automated fixes

* align version with react-router

* sync to react-router

* sync with react-router

* sync navigate tests to react-router

* ci: apply automated fixes

* use Solid.JSX.Element consistently instead of Solid.JSXElement

* remove irrelevant test

* ci: apply automated fixes

* remove unused suite

* lint

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
tannerlinsley pushed a commit that referenced this pull request Feb 25, 2025
@birkskyum @autofix-ci
@brenelz @SeanCassiere @tannerlinsley
feat(solid-router): Add a SolidJS driver for TanStack Router (#3276)
6babbf7 
* copy react-router

* update

* Move forward branch

* cleanup

* cleanup

* add publish

* bump deps

* ci: apply automated fixes

* remove unused imports

* ci: apply automated fixes

* bump  vite plugin solid

* fix imports

* ci: apply automated fixes

* remove react lint from solid-router

* fix types

* ci: apply automated fixes

* add structuralSharing

* downgrade vite plugin solid

* fix scroll-restoration in solid-router

* fix Transitioner

* fix imports from ScrollRestoration

* Fix tests

* Fix more tests

* Remove the react $$typeof

* add accessors to useLocation

* add remountDeps

* cleanup

* remove tanstack/store

* format

* add missing call to setupScrollRestoration

* format

* add optional

* align match component

* make matches a signal

* Bump vite-plugin-solid to stable

* add missing await

* Fix unknown error

* Tweak the tests to call functions

* remove unused vars

* fix lockfile

* Down to 25 failures

* Remove .only

* call search()

* remove the structuralSharing

* fix type test

* fix structuralSharing

* comment out structured sharing validation check

* fix typings

* comment out serialization check

* comment out serialization check

* cleanup

* improve types of useSearch

* fix "when setting search params with 2 parallel navigate calls"

* fix useParams

* fix types

* fix useParams types

* cleanup debug

* fix link data loader

* fix data loader signal

* fix type test

* fix Link "when navigating away from a route with a loader that errors"

* setup on() simpler

* make initial load a createRenderEffect

* Fix some link preload tests

* add accessor to UseMatchRoute

* fix: when navigating to /posts with a beforeLoad that returns context

* call parentRouteId

* re-enable invariant

* fix when navigating from /invoices to ./invoiceId and the current route is /posts/$postId/details

* use memo for prev

* remove browserhistory  workaround

* fix  "after a navigation, should have emitted the "onResolved" event twice"

* skip remount

* add types to useSearch

* fix search middleware

* don't need a getter

* sync react-router

* solid kitchen sink

* add the example to workspace

* lockfile

* fix solid kitchensink name

* add solid template

* fix example

* rename react to solid

* work on example

* add accessor

* fix type tests

* Fix login in example

* Don't destructure

* Fix stuck on pending component

* Fix where loaderData can be undefined

* Use For component

* More refactor

* Hacky way to fix loading spinner

* Fix one test

* Better MatchRoute fix

* Down to 1 failing test

* Fix last test

* cleanup subscription

* lockfile

* eslint

* ci: apply automated fixes

* fix router-core lint

* ci: apply automated fixes

* add e2e test for solid-router

* ci: apply automated fixes

* work on solid-router e2e suites

* fix comment

* use solid-virtualizer

* work on scroll-restauration

* work on scroll-restauration

* skip react-specific useRenderEffect test

* fix errorcomponent being used before it's defined

* set solid target for esbuild

* ci: apply automated fixes

* fix rspack tests

* fix query tets

* add solid-query example

* use memo for post

* add memo for posts

* fix example

* add jsx compiler flags to esbuild commands

* add esbuild-plugin-solid

* Fix some e2e

* ci: apply automated fixes

* port #3423 from react-router

* fix useLoaderData test-d

* add codeSplitGroupings

* Scroll restoration fixes

* add asset headcontent script

* remove solid-router-copy

* fix react use

* fix scroll restoration test

* skip esbuild because it's broken in react-router

* wait for timeout

* update scroll-restoration to match react

* useLocation

* use on() in match

* align useNavigate with react-router

* lockfile

* fix Scripts test

* align __TSR_SSR__ in ScriptOnce

* remove solid-router from publish

* lint

* ci: apply automated fixes

* align to react-router

* port over "exclude props from state equality check to prevent history push for equal url and state"

* align with react-router

* add shouldThrow

* fix typePrimitives

* use searchStr to fix the search middleware

* ci: add solid-router to the labeler

* use patched vite-plugin-solid

* eslint

* ci: apply automated fixes

* use vite-plugin-solid 2.11.2

* remove only modifier

* move vite-plugin-solid peerDep to router-plugin

* use latest vite-plugin-solid

* move vitest to root

* bump vitest

* revert onRendered

* lint

* add to publish

* fix scroll restoration

* ci: apply automated fixes

* align version with react-router

* sync to react-router

* sync with react-router

* sync navigate tests to react-router

* ci: apply automated fixes

* use Solid.JSX.Element consistently instead of Solid.JSXElement

* remove irrelevant test

* ci: apply automated fixes

* remove unused suite

* lint

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@schiller-manuel @autofix-ci @leesb971204
fix(react-router): fix path param handling with relative navigation (T…
743e488 
…anStack#3423)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci
@brenelz @SeanCassiere @leesb971204
feat(solid-router): Add a SolidJS driver for TanStack Router (TanStac…
fc7ae6e 
…k#3276)

* copy react-router

* update

* Move forward branch

* cleanup

* cleanup

* add publish

* bump deps

* ci: apply automated fixes

* remove unused imports

* ci: apply automated fixes

* bump  vite plugin solid

* fix imports

* ci: apply automated fixes

* remove react lint from solid-router

* fix types

* ci: apply automated fixes

* add structuralSharing

* downgrade vite plugin solid

* fix scroll-restoration in solid-router

* fix Transitioner

* fix imports from ScrollRestoration

* Fix tests

* Fix more tests

* Remove the react $$typeof

* add accessors to useLocation

* add remountDeps

* cleanup

* remove tanstack/store

* format

* add missing call to setupScrollRestoration

* format

* add optional

* align match component

* make matches a signal

* Bump vite-plugin-solid to stable

* add missing await

* Fix unknown error

* Tweak the tests to call functions

* remove unused vars

* fix lockfile

* Down to 25 failures

* Remove .only

* call search()

* remove the structuralSharing

* fix type test

* fix structuralSharing

* comment out structured sharing validation check

* fix typings

* comment out serialization check

* comment out serialization check

* cleanup

* improve types of useSearch

* fix "when setting search params with 2 parallel navigate calls"

* fix useParams

* fix types

* fix useParams types

* cleanup debug

* fix link data loader

* fix data loader signal

* fix type test

* fix Link "when navigating away from a route with a loader that errors"

* setup on() simpler

* make initial load a createRenderEffect

* Fix some link preload tests

* add accessor to UseMatchRoute

* fix: when navigating to /posts with a beforeLoad that returns context

* call parentRouteId

* re-enable invariant

* fix when navigating from /invoices to ./invoiceId and the current route is /posts/$postId/details

* use memo for prev

* remove browserhistory  workaround

* fix  "after a navigation, should have emitted the "onResolved" event twice"

* skip remount

* add types to useSearch

* fix search middleware

* don't need a getter

* sync react-router

* solid kitchen sink

* add the example to workspace

* lockfile

* fix solid kitchensink name

* add solid template

* fix example

* rename react to solid

* work on example

* add accessor

* fix type tests

* Fix login in example

* Don't destructure

* Fix stuck on pending component

* Fix where loaderData can be undefined

* Use For component

* More refactor

* Hacky way to fix loading spinner

* Fix one test

* Better MatchRoute fix

* Down to 1 failing test

* Fix last test

* cleanup subscription

* lockfile

* eslint

* ci: apply automated fixes

* fix router-core lint

* ci: apply automated fixes

* add e2e test for solid-router

* ci: apply automated fixes

* work on solid-router e2e suites

* fix comment

* use solid-virtualizer

* work on scroll-restauration

* work on scroll-restauration

* skip react-specific useRenderEffect test

* fix errorcomponent being used before it's defined

* set solid target for esbuild

* ci: apply automated fixes

* fix rspack tests

* fix query tets

* add solid-query example

* use memo for post

* add memo for posts

* fix example

* add jsx compiler flags to esbuild commands

* add esbuild-plugin-solid

* Fix some e2e

* ci: apply automated fixes

* port TanStack#3423 from react-router

* fix useLoaderData test-d

* add codeSplitGroupings

* Scroll restoration fixes

* add asset headcontent script

* remove solid-router-copy

* fix react use

* fix scroll restoration test

* skip esbuild because it's broken in react-router

* wait for timeout

* update scroll-restoration to match react

* useLocation

* use on() in match

* align useNavigate with react-router

* lockfile

* fix Scripts test

* align __TSR_SSR__ in ScriptOnce

* remove solid-router from publish

* lint

* ci: apply automated fixes

* align to react-router

* port over "exclude props from state equality check to prevent history push for equal url and state"

* align with react-router

* add shouldThrow

* fix typePrimitives

* use searchStr to fix the search middleware

* ci: add solid-router to the labeler

* use patched vite-plugin-solid

* eslint

* ci: apply automated fixes

* use vite-plugin-solid 2.11.2

* remove only modifier

* move vite-plugin-solid peerDep to router-plugin

* use latest vite-plugin-solid

* move vitest to root

* bump vitest

* revert onRendered

* lint

* add to publish

* fix scroll restoration

* ci: apply automated fixes

* align version with react-router

* sync to react-router

* sync with react-router

* sync navigate tests to react-router

* ci: apply automated fixes

* use Solid.JSX.Element consistently instead of Solid.JSXElement

* remove irrelevant test

* ci: apply automated fixes

* remove unused suite

* lint

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The relative routing does not allow updating the path params using the <Link> component. Cannot update path params when navigating to '.'
1 participant
@schiller-manuel