Skip to content

ci(codecov): update config #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 7, 2024
Merged

ci(codecov): update config #7503

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b7ddfaa
ci(codecov): update threshold
manudeli Jun 1, 2024
7d35a2e
Merge branch 'main' into ci/codecov-threshold
manudeli Jun 1, 2024
14f1d67
Merge branch 'main' into ci/codecov-threshold
manudeli Jun 1, 2024
3195ebe
Merge branch 'main' into ci/codecov-threshold
manudeli Jun 1, 2024
b840389
ci(codecov): update target as auto
manudeli Jun 1, 2024
fc32bd9
ci(codecov): update comment config
manudeli Jun 1, 2024
b07ab69
Merge branch 'main' into ci/codecov-threshold
manudeli Jun 2, 2024
7e0a92c
Merge branch 'main' into ci/codecov-threshold
manudeli Jun 2, 2024
deb4f64
Merge branch 'main' into ci/codecov-threshold
manudeli Jun 3, 2024
8c0a5ee
Merge branch 'main' into ci/codecov-threshold
manudeli Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,17 @@ coverage:
status:
project:
default:
target: 90%
target: auto
Copy link
Collaborator Author

@manudeli manudeli Jun 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, different thresholds per package would be really appreciated. We have vastly different coverage per package

@TkDodo https://docs.codecov.com/docs/quick-start#tips-and-tricks

status.project.default.target: auto compares coverage to the previous base commit

image

threshold: 1%
base: auto

comment:
layout: 'header, reach, diff, flags, components'
behavior: default
require_changes: false
Copy link
Collaborator Author

@manudeli manudeli Jun 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new baseline is uploaded correctly, but why don't we see the CI check here or a comment from the bot?

@TkDodo comment.require_changes: false should force make comment from the bot without changes

https://docs.codecov.com/docs/quick-start#tips-and-tricks
image

require_base: false
require_head: true
hide_project_coverage: false

component_management:
individual_components:
Expand Down