-
-
Couldn't load subscription status.
- Fork 3.5k
ci(codecov): update config #7503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8c0a5ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c0a5ee:
|
|
I don't know why codecov is suddenly failing, but cherry picking this commit in my PR still results in a codecov error. |
|
For some reason codecov shows a commit from 3 months ago as base instead of the last commit on main. |
|
There is this error message for codecov uploads on main ci: |
|
I think this can only be fixed by using a token to upload the reports. |
|
new baseline is uploaded correctly, but why don't we see the CI check here or a comment from the bot? |
|
also, different thresholds per |
We could make it informational
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnoud-dv @TkDodo I updated some codes, In my opinion, we can use this config. confirm it please.
| comment: | ||
| layout: 'header, reach, diff, flags, components' | ||
| behavior: default | ||
| require_changes: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new baseline is uploaded correctly, but why don't we see the CI check here or a comment from the bot?
@TkDodo comment.require_changes: false should force make comment from the bot without changes
| project: | ||
| default: | ||
| target: 90% | ||
| target: auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, different thresholds per package would be really appreciated. We have vastly different coverage per package
@TkDodo https://docs.codecov.com/docs/quick-start#tips-and-tricks
status.project.default.target: auto compares coverage to the previous base commit


ref: #7502
I update codecov coverage threshold. because all pr could be as error in GitHub workflow checks