Skip to content

Conversation

@manudeli
Copy link
Collaborator

@manudeli manudeli commented Jun 1, 2024

ref: #7502

image

I update codecov coverage threshold. because all pr could be as error in GitHub workflow checks

@vercel
Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 1:07pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8c0a5ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@manudeli manudeli marked this pull request as ready for review June 1, 2024 10:19
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c0a5ee:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@arnoud-dv
Copy link
Collaborator

I don't know why codecov is suddenly failing, but cherry picking this commit in my PR still results in a codecov error.

@arnoud-dv
Copy link
Collaborator

For some reason codecov shows a commit from 3 months ago as base instead of the last commit on main.

@arnoud-dv
Copy link
Collaborator

There is this error message for codecov uploads on main ci:

info - 2024-05-27 18:16:24,691 -- ci service found: github-actions
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

@arnoud-dv
Copy link
Collaborator

I think this can only be fixed by using a token to upload the reports.

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 1, 2024

new baseline is uploaded correctly, but why don't we see the CI check here or a comment from the bot?

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 1, 2024

also, different thresholds per package would be really appreciated. We have vastly different coverage per package

@arnoud-dv
Copy link
Collaborator

also, different thresholds per package would be really appreciated. We have vastly different coverage per package

We could make it informational

  1. Not ready to start using blocking status checks? Set them as informational while you and your team get started with code coverage.

@manudeli manudeli marked this pull request as draft June 1, 2024 20:01
Copy link
Collaborator Author

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnoud-dv @TkDodo I updated some codes, In my opinion, we can use this config. confirm it please.

comment:
layout: 'header, reach, diff, flags, components'
behavior: default
require_changes: false
Copy link
Collaborator Author

@manudeli manudeli Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new baseline is uploaded correctly, but why don't we see the CI check here or a comment from the bot?

@TkDodo comment.require_changes: false should force make comment from the bot without changes

https://docs.codecov.com/docs/quick-start#tips-and-tricks
image

project:
default:
target: 90%
target: auto
Copy link
Collaborator Author

@manudeli manudeli Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, different thresholds per package would be really appreciated. We have vastly different coverage per package

@TkDodo https://docs.codecov.com/docs/quick-start#tips-and-tricks

status.project.default.target: auto compares coverage to the previous base commit

image

@manudeli manudeli marked this pull request as ready for review June 1, 2024 20:15
@manudeli manudeli changed the title ci(codecov): update threshold ci(codecov): update config Jun 1, 2024
@manudeli manudeli marked this pull request as draft June 1, 2024 20:23
@manudeli manudeli marked this pull request as ready for review June 1, 2024 20:31
@TkDodo TkDodo merged commit 7110ea3 into TanStack:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants