Skip to content

chore: devinxi start example #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2025

Conversation

Balastrong
Copy link
Member

Update start to the devinxi version

Copy link

nx-cloud bot commented Jun 18, 2025

View your CI Pipeline Execution ↗ for commit ef65ff1

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 21s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-05 07:49:36 UTC

Copy link

pkg-pr-new bot commented Jun 18, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1584

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1584

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1584

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1584

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1584

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1584

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1584

commit: ef65ff1

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (cca8de7) to head (ef65ff1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   90.51%   90.49%   -0.02%     
==========================================
  Files          37       37              
  Lines        1686     1683       -3     
  Branches      421      421              
==========================================
- Hits         1526     1523       -3     
  Misses        143      143              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SutuSebastian
Copy link

  1. is it normal behaviour after form submit to display the raw response and not return it into state?
Screen.Recording.2025-06-19.at.11.48.56.mov
  1. If we update the packages we get the following error:
Screenshot 2025-06-19 at 11 46 54 Screenshot 2025-06-19 at 11 47 26

CC @tannerlinsley @crutchcorn

@kusiewicz
Copy link
Contributor

kusiewicz commented Jun 26, 2025

@SutuSebastian

  1. If we update the packages we get the following error:

TanStack/router#4409

@Balastrong
Copy link
Member Author

Balastrong commented Aug 5, 2025

@SutuSebastian

  1. is it normal behaviour after form submit to display the raw response and not return it into state?

In the current implementation, yes. I'm only updating Start to the latest version here but this can indeed be improved later :)
Currently Form doesn't have a field in the state to keep a success or response message but maybe this can be introduced for SSR adapters... or the response could flow to onSubmit... or a new onServerSubmit... just thinking out loud at this point :D

I'd say ideas are always welcome!

@Balastrong Balastrong merged commit 15187c5 into TanStack:main Aug 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants