fix: parent tags in tag editor are uneditable #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
CyanVoxel
approved these changes
Aug 31, 2025
Member
There was a problem hiding this comment.
Looks good to me - the only quirk is that you can get pretty deep into some editing chains and the successive modals don't update whenever the next one in line updates a parent tag value, but I think it's fair to say that that's out of scope for this...
(Also while reviewing this I discovered #1074 before the patch, so, yay?)
Anyway, thank you for your work on this!
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in TagStudio Development
Contributor
Author
|
No problem! Glad I could get my PR in before 9.5.4 😮💨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1055
Enables the Edit context menu item for Parent Tags within the
BuildTagPanelBefore
After
Tasks Completed