Skip to content

develp branch 작업내용 머지 : develop -> main#264

Merged
heeeeyong merged 2 commits intomainfrom
develop
Sep 26, 2025
Merged

develp branch 작업내용 머지 : develop -> main#264
heeeeyong merged 2 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Sep 26, 2025

이하동일

Summary by CodeRabbit

  • 신기능
    • 라우트별 페이지 제목이 자동 설정됩니다. 다국어 경로(예: 홈, 피드, 공지, 그룹, 방의 추억, 마이페이지, 검색)를 인식해 적절한 제목을 표시하며, 규칙에 없으면 기본 제목 “THIP”을 사용합니다.
  • 개선
    • 페이지 이동 시 경로·쿼리·해시 정보를 포함해 페이지 뷰가 보다 안정적으로 기록됩니다.

@heeeeyong heeeeyong self-assigned this Sep 26, 2025
@heeeeyong heeeeyong added the 🌏 Deploy 배포 관련 label Sep 26, 2025
@vercel
Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Sep 26, 2025 7:10am

@coderabbitai
Copy link

coderabbitai bot commented Sep 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

라우트 변경 시 현재 경로를 기반으로 문서 제목을 규칙 매칭으로 결정하고 기본값(“THIP”)을 적용한 뒤, 검색·해시를 포함한 전체 경로로 sendPageView를 호출하도록 Layout의 페이지 뷰 처리 로직을 갱신했습니다. 다국어 라우트별 제목 규칙이 추가되었습니다.

Changes

Cohort / File(s) Summary
Route-aware title & page view
src/components/common/Layout.tsx
기존의 단순 페이지뷰 호출을, 경로 정규식 규칙으로 제목을 계산·설정한 후 sendPageView를 호출하는 흐름으로 변경. 기본 제목 "THIP" 추가. 대상 경로 예: /, /feed, /notice, /group, /rooms/.../memory, /mypage, /search.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Router as Router
  participant Layout as Layout (useEffect)
  participant TitleRules as Title Rules
  participant Document as document.title
  participant Analytics as sendPageView

  Router->>Layout: Route change (pathname, search, hash)
  Layout->>TitleRules: Match pathname against regex rules
  TitleRules-->>Layout: Matched title or null
  Layout->>Document: Set title (matched or "THIP")
  Layout->>Analytics: sendPageView(pathname + search + hash)
  Note over Layout,Analytics: Executes on each route change
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

폴짝, 경로 따라 제목을 골라
"/"엔 인사, "feed"엔 소식 몰아
문서의 왕관 반짝- "THIP"이 기본
해시와 검색도 챙겨, 뷰는 기록
토끼는 귀를 세워, 라우트에 춤춘다 🐇✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 601b648 and c21ecf3.

📒 Files selected for processing (1)
  • src/components/common/Layout.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@heeeeyong heeeeyong merged commit 0224565 into main Sep 26, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌏 Deploy 배포 관련

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant