Skip to content

develp branch 작업내용 머지 : develop -> main#241

Merged
heeeeyong merged 4 commits intomainfrom
develop
Sep 12, 2025
Merged

develp branch 작업내용 머지 : develop -> main#241
heeeeyong merged 4 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Sep 12, 2025

이하동일

Summary by CodeRabbit

  • 신규 기능
    • 없음
  • 버그 수정
    • 모바일/터치 환경에서 가로 스와이프와 제스처가 차단되던 문제를 해소하여 기본 스크롤/제스처 동작을 복원했습니다.
  • 작업(Chores)
    • 앱 전역에 Google Analytics 초기화 및 SPA 페이지뷰 수집을 추가했습니다.
    • 불필요한 서드파티 Maze 스니펫을 제거했습니다.

@heeeeyong heeeeyong self-assigned this Sep 12, 2025
@heeeeyong heeeeyong added the 🌏 Deploy 배포 관련 label Sep 12, 2025
@vercel
Copy link

vercel bot commented Sep 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Sep 12, 2025 7:00am

@coderabbitai
Copy link

coderabbitai bot commented Sep 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

인덱스에서 제스처 차단 스크립트와 Maze 스니펫을 제거했다. 신규 GA 모듈을 추가하고, 앱 부팅 시 GA 초기화 및 라우트 변경 시 수동 페이지뷰 전송을 연결했다. 퍼블릭 API 시그니처 변경은 없다.

Changes

Cohort / File(s) Summary
HTML 정리 및 스니펫 제거
index.html
overscroll/touch/gesture 차단 스타일·리스너 삭제, Maze Universal Snippet 로더와 세션 스토리지 로직 제거. 기존 applyVv 스크립트 유지.
Analytics 초기화
src/lib/ga.ts, src/main.tsx
신규 GA 모듈 추가: GA_ID, initGA(), sendPageView() 도입. 앱 시작 시 initGA() 호출하여 gtag 스크립트 주입 및 send_page_view 비활성화 구성.
SPA 페이지뷰 전송
src/components/common/Layout.tsx
useLocation/useEffect로 라우트 변경 감지 시 sendPageView(pathname+search+hash) 호출. 렌더 경로(ScrollToTop/Outlet)는 동일.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Browser
  participant App as React App
  participant GA as GA Module (gtag)
  participant GASvc as Google Analytics

  User->>Browser: 페이지 로드
  Browser->>App: main.tsx 실행
  App->>GA: initGA()
  rect rgba(230,245,255,0.6)
    note right of GA: gtag.js 스크립트 주입 및 초기화<br/>send_page_view: false 설정
    GA->>GASvc: config(Measurement ID)
  end

  User->>App: 라우팅 이동
  App->>GA: sendPageView(path)
  rect rgba(235,255,235,0.6)
    GA->>GASvc: event('page_view', { title, location, path })
    note over GA,GASvc: SPA 수동 페이지뷰 전송
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

휘릭—가로 스와이프, 이젠 막지 않아요!
통통—토끼 발자국, 라우트 따라 가나요.
gtag 깡총, 페이지뷰 퐁당!
미로는 사라지고, 길은 곧장.
코드밭에 바람 불어, 데이터 톡톡 익어가요 🐇📈

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c0adbd5 and a401d5f.

📒 Files selected for processing (4)
  • index.html (0 hunks)
  • src/components/common/Layout.tsx (1 hunks)
  • src/lib/ga.ts (1 hunks)
  • src/main.tsx (1 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌏 Deploy 배포 관련

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant