Skip to content

develp branch 작업내용 머지 : develop -> main#182

Merged
heeeeyong merged 2 commits intomainfrom
develop
Aug 20, 2025
Merged

develp branch 작업내용 머지 : develop -> main#182
heeeeyong merged 2 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 20, 2025

이하동일

Summary by CodeRabbit

  • 버그 수정
    • 내 프로필(내 피드) 조회 시 팔로우 버튼이 기본적으로 표시되지 않도록 로직을 수정했습니다.
    • MyFeed 페이지에서 자기 자신 컨텍스트를 명확히 전달해 팔로우 버튼 표시 동작을 일관화했습니다.
    • 팔로우리스트 화면에서는 자기 자신 여부와 관계없이 팔로우 버튼이 항상 표시되도록 조정했습니다.

@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 20, 2025 1:04pm

@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

OtherFeed에 선택적 prop isMyself가 추가되고, 기본 follow 버튼 표시 조건이 !profileData.isWriter && !isMyself로 조정됨. MyFeedPage는 OtherFeed에 isMyself={true}를 전달. UserProfileItem은 type==='followlist'에서 isMyself와 무관하게 follow 버튼을 렌더링하도록 변경.

Changes

Cohort / File(s) Summary of Changes
OtherFeed isMyself prop & default follow-button logic
src/components/feed/OtherFeed.tsx, src/pages/feed/MyFeedPage.tsx
OtherFeedProps에 isMyself?: boolean 추가 및 컴포넌트 인자 반영. showFollowButton 기본값을 !profileData.isWriter && !isMyself로 변경. MyFeedPage에서 OtherFeed 호출 시 isMyself={true} 전달.
UserProfileItem followlist 렌더링 조건 조정
src/components/feed/UserProfileItem.tsx
followlist 컨텍스트에서 isMyself 조건을 제거하여 type==='followlist'이면 항상 follow 버튼을 렌더링. 네비게이션 동작은 기존대로 isMyself에 따라 유지.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant MyFeedPage
  participant OtherFeed
  participant Profile as Profile (in OtherFeed)
  participant UserProfileItem

  User->>MyFeedPage: Open My Feed
  MyFeedPage->>OtherFeed: render({ isMyself: true, ... })
  OtherFeed->>Profile: render(showFollowButton = !isWriter && !isMyself)
  Note right of Profile: isMyself=true → 기본적으로 버튼 숨김

  User->>OtherFeed: View follow list
  OtherFeed->>UserProfileItem: render({ type: 'followlist', isMyself })
  UserProfileItem-->>User: Show Follow Button (type==='followlist')
  Note over UserProfileItem: isMyself와 무관하게 버튼 렌더링
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

✨ Feature

Poem

ㄷㄷ 폴로 버튼, 토글 톡톡! 🐇
내 피드라면 살짝 숨고, 남 피드면 또록또록.
팔로리스트엔 언제나 쏙—
당근밭처럼 규칙 쏙쏙.
깡총! 새 prop 타고 흐름도 반듯하게 정렬!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5ca4638 and 0d2ebae.

📒 Files selected for processing (3)
  • src/components/feed/OtherFeed.tsx (3 hunks)
  • src/components/feed/UserProfileItem.tsx (1 hunks)
  • src/pages/feed/MyFeedPage.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong self-assigned this Aug 20, 2025
@heeeeyong heeeeyong added the 🐞 BugFix Something isn't working label Aug 20, 2025
@heeeeyong heeeeyong merged commit 9969b32 into main Aug 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant