Skip to content

fix: 띱하기가 내 프로필에서 보이는 에러 수정#181

Merged
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates
Aug 20, 2025
Merged

fix: 띱하기가 내 프로필에서 보이는 에러 수정#181
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 20, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

Summary by CodeRabbit

  • 버그 수정
    • 내 프로필을 볼 때 표시되던 팔로우 버튼을 숨기도록 수정했습니다. 이제 작성자이거나 본인인 경우 버튼이 노출되지 않습니다.
    • 팔로우/팔로잉 목록에서 각 사용자 옆의 팔로우 버튼이 항상 표시되도록 일관성을 개선했습니다. 버튼으로 즉시 팔로우/언팔로우할 수 있으며 스낵바 알림은 기존과 동일하게 제공됩니다.
  • 기타
    • 내 피드 화면의 프로필 표시 로직을 정비해 위 동작이 안정적으로 적용되도록 했습니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

OtherFeed에 isMyself prop이 추가되고, showFollowButton의 기본값이 (!profileData.isWriter && !isMyself)로 변경되었습니다. MyFeedPage에서 OtherFeed 호출 시 isMyself={true}를 전달합니다. UserProfileItem에서는 followlist 항목에서 isMyself와 무관하게 팔로우 버튼을 표시하도록 조건이 변경되었습니다.

Changes

Cohort / File(s) Summary
Feed prop 추가 및 기본 표시 로직 변경
src/components/feed/OtherFeed.tsx, src/pages/feed/MyFeedPage.tsx
OtherFeedProps에 isMyself?: boolean 추가 및 컴포넌트에 전달. showFollowButton 기본값을 (!profileData.isWriter && !isMyself)로 수정. MyFeedPage에서 <OtherFeed ... isMyself={true} />로 사용.
Followlist 아이템 버튼 표시 조건 변경
src/components/feed/UserProfileItem.tsx
type === 'followlist' && !isMyself에서 type === 'followlist' &&로 변경하여 followlist에서는 자기 자신 여부와 무관하게 팔로우 버튼 표시. 토글 동작과 API 연동(postFollow), 스낵바 로직은 변경 없음.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as 사용자
  participant M as MyFeedPage
  participant O as OtherFeed (isMyself)
  participant P as Profile 렌더러
  participant L as UserProfileItem
  participant API as postFollow API

  U->>M: 내 피드 페이지 접속
  M->>O: 렌더링 (isMyself=true, profileData)
  O->>P: showFollowButton = (!isWriter && !isMyself)
  Note right of P: isMyself=true이면 버튼 숨김

  rect rgba(200,220,255,0.25)
    Note over L: followlist 컨텍스트
    O->>L: 렌더링(type='followlist')
    Note right of L: isMyself와 무관하게 버튼 표시
    U->>L: 팔로우 토글 클릭
    L->>API: postFollow(userId)
    API-->>L: 응답(followed 상태)
    L-->>U: 상태 업데이트 및 스낵바
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

🐞 BugFix

Poem

귀가 팔랑, 피드로 점프!
내 프로필엔 버튼 잠깐 숨고,
팔로우리스트엔 반짝 등장—눌러봐 쿡!
토글 톡, 스낵바 똑,
초원 위 코드도 질서정연—깡총!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5f021f3 and 9d8de24.

📒 Files selected for processing (3)
  • src/components/feed/OtherFeed.tsx (3 hunks)
  • src/components/feed/UserProfileItem.tsx (1 hunks)
  • src/pages/feed/MyFeedPage.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/minor-updates

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong merged commit 0d2ebae into develop Aug 20, 2025
2 of 3 checks passed
@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 20, 2025 1:03pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant