Merged
Conversation
- 경우에 맞춰 생성한 token을 메모리 저장소에 저장 - token을 찾을 수 있는 key를 포함해서 redirect
[hotfix] 소셜 로그인 관련 코드 수정
|
Caution Review failedThe pull request is closed. WalkthroughOAuth2 로그인 후 토큰을 즉시 쿠키로 내려주지 않고, 5분 TTL의 임시 저장소(LoginTokenStorage)에 보관한 뒤 loginTokenKey로 리다이렉트합니다. 클라이언트는 /api/set-cookie로 key를 전송해 쿠키를 발급받습니다. JWT 필터는 access/temp 쿠키 모두 인식하며, CORS 원본 구성이 업데이트되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant OAuth2 as OAuth2 Provider
participant App as Server
participant Store as LoginTokenStorage
participant Client
User->>OAuth2: Login
OAuth2-->>App: Authentication success
App->>Store: put(loginTokenKey, type, token, 5m)
App-->>Client: 302 Redirect ?loginTokenKey=KEY
Client->>App: POST /api/set-cookie {loginTokenKey: KEY}
App->>Store: consume(KEY)
Store-->>App: Entry(type, token) or null
App-->>Client: Set-Cookie (access_token or temp_token)
Client->>App: Subsequent API request
Client->>App: Cookie: access_token/temp_token
App->>App: JwtAuthenticationFilter extracts cookie
App-->>Client: Response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요
Summary by CodeRabbit